Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH Add markdown-php-codesniffer repo #25

Merged
merged 1 commit into from
Nov 13, 2023
Merged

ENH Add markdown-php-codesniffer repo #25

merged 1 commit into from
Nov 13, 2023

Conversation

GuySartorelli
Copy link
Member

@GuySartorelli GuySartorelli mentioned this pull request Nov 13, 2023
Closed
2 tasks
GuySartorelli
GuySartorelli commented Nov 13, 2023
View reviewed changes
funcs_utils.php
Comment on lines -340 to +354
error("Could work out current major for developer-docs from branch $currentBranch");
error("Could not work out current major for developer-docs from branch $currentBranch");
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not technically part of the purpose of this PR but it's a simple fix to make here and might save a minor headache later on

@emteknetnz emteknetnz merged commit 0b49a7e into silverstripe:main Nov 13, 2023
1 check passed
@emteknetnz emteknetnz deleted the pulls/main/add-markdown-php-codesniffer branch November 13, 2023 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emteknetnz emteknetnz emteknetnz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GuySartorelli @emteknetnz