Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add image tag to shortcode task #227
Add image tag to shortcode task #227
Changes from 35 commits
23d3188
b63a0f2
ae50a21
e07504d
279e5d6
a963d42
69cee26
e1234a5
75bb5d9
0baf678
93ed167
534e930
3604e27
87db65f
efaaa86
b335c68
5676e2a
e836fd6
904fa73
0ff0df7
a267a8b
0c3a7de
6745acf
d8159dc
4336e1b
9c1faf1
5fa823a
100a298
a23346d
dba0f05
7ec9937
574e4eb
f198e08
8be3ca4
41816bf
de7bf81
1b55166
b43833f
d6cb934
a5897db
5385760
96d5f26
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just making the error message a little clearer for developers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe give this method a slighlty different name, because
getNewContent
could be confuse with a getter.e.g.:
normaliseContent
,convertFileShortCode
,migrateContent
, or whatever else catches your fancy.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use the logger instead.