Add periodic logging every 100th file iterated #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnsl48
previously requested changes
Apr 4, 2019
ScopeyNZ
reviewed
Apr 4, 2019
dnsl48
reviewed
Apr 10, 2019
dnsl48
approved these changes
Apr 10, 2019
dnsl48
suggested changes
Apr 10, 2019
ScopeyNZ
reviewed
Apr 10, 2019
|
@robbieaverill @ScopeyNZ good to merge? |
|
Looks good, I definitely missed this when upgrading a site this week! Could you squash the commits @bergice? |
bergice
force-pushed
the
pulls/1/logging
branch
from
3062634
to
7aebc14
Compare
|
Squashed, and all good to go! 🚀 |
chillu
reviewed
Apr 15, 2019
chillu
requested changes
Apr 15, 2019
…` so that output is echoed during CLI and web request runs
…pe-assets into pulls/1/logging
ScopeyNZ
suggested changes
Apr 17, 2019
ScopeyNZ
reviewed
Apr 17, 2019
6 tasks
Also make logger work for stdout
Co-Authored-By: bergice <bergice@users.noreply.github.com>
Co-Authored-By: bergice <bergice@users.noreply.github.com>
dnsl48
suggested changes
Apr 17, 2019
robbieaverill
dismissed
their stale review
The PR has changed a lot, dismissing my review
chillu
approved these changes
Apr 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.