Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT Remove unused dev-dependency #84

Merged

Conversation

GuySartorelli
Copy link
Member

Fixes https://github.com/silverstripe/silverstripe-mimevalidator/actions/runs/11061570379/job/30734529021

  Problem 1
    - Root composer.json requires silverstripe/framework ^6 -> satisfiable by silverstripe/framework[6.x-dev].
    - silverstripe/framework 6.x-dev requires nikic/php-parser ^5.1.0 -> found nikic/php-parser[v5.1.0, v5.2.0] but it conflicts with your root composer.json require (^4.15.0).
  Problem 2
    - silverstripe/framework 6.x-dev requires nikic/php-parser ^5.1.0 -> found nikic/php-parser[v5.1.0, v5.2.0] but it conflicts with your root composer.json require (^4.15.0).
    - silverstripe/installer 6.x-dev requires silverstripe/login-forms 6.x-dev -> satisfiable by silverstripe/login-forms[6.x-dev].
    - silverstripe/login-forms 6.x-dev requires silverstripe/framework ^6 -> satisfiable by silverstripe/framework[6.x-dev].
    - Root composer.json requires silverstripe/installer 6.x-dev -> satisfiable by silverstripe/installer[6.x-dev].

nikic/php-parser dev dependency doesn't seem to even be used, so I've just removed it outright.

Issue

@GuySartorelli GuySartorelli changed the base branch from 3 to 4 September 30, 2024 01:46
@GuySartorelli GuySartorelli changed the title Pulls/4/make installable MNT Remove unused dev-dependency Sep 30, 2024
@emteknetnz emteknetnz merged commit 7a85b7e into silverstripe:4 Sep 30, 2024
7 checks passed
@emteknetnz emteknetnz deleted the pulls/4/make-installable branch September 30, 2024 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants