don't trigger permissionFailure when it's not needed #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My understanding is that the underlying issue this aims to fix is a problem for CMS 4 as well - please retarget this PR to the |
(cherry picked from commit a19ed3e)
|
done |
GuySartorelli
approved these changes
Aug 17, 2023
|
This change will be automatically tagged once CI has finished running on the branch, and will be automatically merged up to and tagged in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #529
LeftAndMain already has a canView check that will use under the hood the alternateAccessCheck
Not trigger the permissionFailure allows proper handling of the error instead of showing a ever loading logo in admin v5