Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MNT Remove unused Translatable #547

Merged
merged 1 commit into from
Oct 15, 2023
Merged

MNT Remove unused Translatable #547

merged 1 commit into from
Oct 15, 2023

Conversation

sabina-talipova
Copy link
Contributor

Description

The Translatable module is no longer in use.

Related issue

@sabina-talipova sabina-talipova mentioned this pull request Oct 13, 2023
Closed
GuySartorelli
GuySartorelli requested changes Oct 13, 2023
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should either target 3.0 if it's to be released as a patch, or 3 if it's to be included in the next minor release. 3.1 is in a change freeze (as it has had the RC tagged) so non-patchable changes shouldn't be targetting that branch.

@sabina-talipova sabina-talipova changed the base branch from 3.1 to 3.0 October 15, 2023 19:41
@sabina-talipova sabina-talipova changed the base branch from 3.0 to 3 October 15, 2023 19:41
GuySartorelli
GuySartorelli approved these changes Oct 15, 2023
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@GuySartorelli GuySartorelli merged commit 2408f3d into silverstripe:3 Oct 15, 2023
12 checks passed
@GuySartorelli GuySartorelli deleted the pulls/3.1/remove-translatable branch October 15, 2023 22:21
@GuySartorelli GuySartorelli mentioned this pull request Oct 15, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sabina-talipova @GuySartorelli