-
Notifications
You must be signed in to change notification settings - Fork 0
Issue 148 forward fixes JDK 25 build stage distroless WORKDIR and jdt2jar helper #151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
eedb416
3426bda
e76b1b7
9b093ed
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| #!/usr/bin/env bash | ||
| # jdt2jar helper script for environments where volume mounts are restricted | ||
| # (e.g., Colima on macOS with projects outside ~/). | ||
| # | ||
| # Usage: | ||
| # ./scripts/jdt2jar.sh <schema.jtd.json> [options...] | ||
| # | ||
| # Example: | ||
| # ./scripts/jdt2jar.sh .tmp/test.jtd.json --output .tmp/test.jar --main | ||
|
|
||
| set -euo pipefail | ||
|
|
||
| WORK_DIR="$HOME/tmp/jdt2jar-work" | ||
| IMAGE="${JDT2JAR_IMAGE:-jdt2jar:latest}" | ||
|
|
||
| mkdir -p "$WORK_DIR" | ||
|
|
||
| # Sync source (respecting .gitignore) | ||
| rsync -a --filter=':- .gitignore' --exclude='.git/' . "$WORK_DIR/" | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
When the requested schema is under any ignored path, this filter omits it from the staging directory while line 22 passes the original path unchanged to the container, so compilation fails with Useful? React with 👍 / 👎. |
||
|
|
||
| # Run jdt2jar in container | ||
| docker run --rm -v "$WORK_DIR:/work" "$IMAGE" "$@" | ||
|
|
||
| # Sync output back (any new .jar or .java files in the work dir) | ||
| rsync -a --include='*.jar' --include='*.java' --exclude='*' "$WORK_DIR/" ./ | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
When Useful? React with 👍 / 👎. |
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This now tells users that codegen requires JDK 25+, but
json-java21-jtd-codegen/pom.xmlandjdt2jar/pom.xmlstill compile with release 24, the parent profile activates on[24,), and both the top-level and codegen READMEs continue to document 24+. Either retain the 24+ minimum here or update the actual build requirement and all user documentation together so JDK 24 users are not incorrectly told the supported path is unavailable.AGENTS.md reference: AGENTS.md:L29-L29
Useful? React with 👍 / 👎.