Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve alignment #387

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Improve alignment #387

wants to merge 3 commits into from

Conversation

Licenser
Copy link
Member

Improve alignment to avoid unaligned memory reads

@Licenser Licenser marked this pull request as ready for review August 31, 2024 19:08
@Licenser Licenser force-pushed the alignment-improvements branch 2 times, most recently from 15c04c8 to ebab1d2 Compare August 31, 2024 19:18
Copy link

Benchmark for e9fee9f

Click to view benchmark
Test Base PR %
apache_builds/simd_json::to_tape_with_buffers 90.9±1.42µs 90.9±3.38µs 0.00%
canada/simd_json::to_tape_with_buffers 3.8±0.13ms 3.7±0.14ms -2.63%
citm_catalog/simd_json::to_tape_with_buffers 1132.5±79.99µs 1117.9±71.08µs -1.29%
event_stacktrace_10kb/simd_json::to_tape_with_buffers 3.6±0.20µs 3.8±0.21µs +5.56%
github_events/simd_json::to_tape_with_buffers 40.1±0.89µs 39.9±0.92µs -0.50%
log/simd_json::to_tape_with_buffers 1525.4±67.75ns 1551.1±79.38ns +1.68%
twitter/simd_json::to_tape_with_buffers 435.5±25.71µs 434.7±23.79µs -0.18%

Copy link

Benchmark for dabe1af

Click to view benchmark
Test Base PR %
apache_builds/simd_json::to_tape_with_buffers 92.0±2.09µs 92.0±2.05µs 0.00%
canada/simd_json::to_tape_with_buffers 3.8±0.18ms 3.7±0.16ms -2.63%
citm_catalog/simd_json::to_tape_with_buffers 1147.1±83.80µs 1128.3±87.86µs -1.64%
event_stacktrace_10kb/simd_json::to_tape_with_buffers 3.7±0.23µs 3.9±0.26µs +5.41%
github_events/simd_json::to_tape_with_buffers 40.5±1.11µs 40.9±1.12µs +0.99%
log/simd_json::to_tape_with_buffers 1588.5±89.25ns 1584.0±107.70ns -0.28%
twitter/simd_json::to_tape_with_buffers 450.6±27.37µs 444.6±23.26µs -1.33%

Copy link

Benchmark for 00d086f

Click to view benchmark
Test Base PR %
apache_builds/simd_json::to_tape_with_buffers 92.5±1.52µs 92.1±1.62µs -0.43%
canada/simd_json::to_tape_with_buffers 3.7±0.12ms 3.7±0.16ms 0.00%
citm_catalog/simd_json::to_tape_with_buffers 1138.2±78.97µs 1123.4±77.18µs -1.30%
event_stacktrace_10kb/simd_json::to_tape_with_buffers 3.8±0.24µs 4.0±0.25µs +5.26%
github_events/simd_json::to_tape_with_buffers 40.9±1.06µs 40.7±1.10µs -0.49%
log/simd_json::to_tape_with_buffers 1562.7±86.43ns 1650.9±117.36ns +5.64%
twitter/simd_json::to_tape_with_buffers 440.6±30.38µs 435.5±26.54µs -1.16%

Copy link

Benchmark for a10a17e

Click to view benchmark
Test Base PR %
apache_builds/simd_json::to_tape_with_buffers 90.7±1.52µs 90.8±2.00µs +0.11%
canada/simd_json::to_tape_with_buffers 3.8±0.16ms 3.6±0.17ms -5.26%
citm_catalog/simd_json::to_tape_with_buffers 1129.8±77.90µs 1121.5±77.25µs -0.73%
event_stacktrace_10kb/simd_json::to_tape_with_buffers 3.7±0.24µs 3.8±0.19µs +2.70%
github_events/simd_json::to_tape_with_buffers 40.4±2.19µs 40.1±0.93µs -0.74%
log/simd_json::to_tape_with_buffers 1577.2±98.29ns 1577.8±89.79ns +0.04%
twitter/simd_json::to_tape_with_buffers 447.7±27.47µs 435.3±23.62µs -2.77%

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 97.72727% with 1 line in your changes missing coverage. Please review.

Project coverage is 71.53%. Comparing base (8a9169b) to head (3aad36b).
Report is 174 commits behind head on main.

Files with missing lines Patch % Lines
src/lib.rs 96.77% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (8a9169b) and HEAD (3aad36b). Click for more details.

HEAD has 7 uploads less than BASE
Flag BASE (8a9169b) HEAD (3aad36b)
128bit 2 0
3 0
beef 2 0
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #387       +/-   ##
===========================================
- Coverage   81.83%   71.53%   -10.30%     
===========================================
  Files          32       51       +19     
  Lines        9992    12340     +2348     
===========================================
+ Hits         8177     8828      +651     
- Misses       1815     3512     +1697     
Flag Coverage Δ
?
128bit ?
beef ?
unittests 71.53% <97.72%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Oct 8, 2024

Benchmark for c0f9298

Click to view benchmark
Test Base PR %
apache_builds/simd_json::to_tape_with_buffers 93.1±1.54µs 92.3±1.35µs -0.86%
canada/simd_json::to_tape_with_buffers 3.9±0.14ms 3.7±0.14ms -5.13%
citm_catalog/simd_json::to_tape_with_buffers 1145.9±83.24µs 1124.9±92.25µs -1.83%
event_stacktrace_10kb/simd_json::to_tape_with_buffers 3.8±0.20µs 4.0±0.22µs +5.26%
github_events/simd_json::to_tape_with_buffers 41.0±0.96µs 41.5±0.98µs +1.22%
log/simd_json::to_tape_with_buffers 1597.1±94.00ns 1585.5±99.97ns -0.73%
twitter/simd_json::to_tape_with_buffers 451.6±29.53µs 444.1±25.44µs -1.66%

Signed-off-by: Heinz N. Gies <heinz@licenser.net>
Signed-off-by: Heinz N. Gies <heinz@licenser.net>
Signed-off-by: Heinz N. Gies <heinz@licenser.net>
Copy link

github-actions bot commented Oct 8, 2024

Benchmark for 97e1857

Click to view benchmark
Test Base PR %
apache_builds/simd_json::to_tape_with_buffers 94.5±3.85µs 93.9±3.39µs -0.63%
canada/simd_json::to_tape_with_buffers 3.8±0.18ms 3.9±0.13ms +2.63%
citm_catalog/simd_json::to_tape_with_buffers 1161.0±85.07µs 1147.2±84.52µs -1.19%
event_stacktrace_10kb/simd_json::to_tape_with_buffers 3.9±0.23µs 4.1±0.26µs +5.13%
github_events/simd_json::to_tape_with_buffers 41.6±1.00µs 41.5±1.17µs -0.24%
log/simd_json::to_tape_with_buffers 1630.9±108.37ns 1708.4±180.21ns +4.75%
twitter/simd_json::to_tape_with_buffers 451.3±29.04µs 450.2±28.02µs -0.24%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant