-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support SPECIES_128 #41
base: main
Are you sure you want to change the base?
Conversation
Thanks for the contribution! I'm a bit busy right now, working on a feature for the parser that I'll hopefully finish this month, so I can't promise when I'll be able to look at your PR, but I'll definitely do so. I believe that the most important thing is to make sure that this change doesn't affect the most common cases (256-bit and 512-bit registers). |
I've run the benchmarks on a machine with Neoverse-N1 CPU:
and the results are indeed unsatisfactory:
I'd like to understand where the disparity between 256/512-bit and 128-bit vectors comes from (see results in README for Intel CPUs). Currently, I don't have space to investigate this. Would you like to do it, or would you like me to come back to it when I have time? |
The way I've implement that feature for 128bit is not the same as the arm64 implementation in original repo. They take a little bit different approach there, but I don't think we need that kind of details here anyway. |
I think your code looks good. By |
That's interesting. My MacBook with m1max gives me different result:
It's still bad, but not even close that bad. |
Should help with #9, the performance is still kind of low though (half of what jsoniter shows)