-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add SimdJsonParser2 base on bitindex #60
base: main
Are you sure you want to change the base?
Conversation
5c92d47
to
3139b2c
Compare
e84e78d
to
e2f0def
Compare
@arouel thanks very much, I have fix the code based on your suggestion. Benchmark testing indicators. refer: Result "org.simdjson.AParseAndSelectFixPathBenchMark.parseMultiValuesForFixPaths_Jackson": Result "org.simdjson.ParseAndSelectFixPathBenchMark.parseMultiValuesForFixPaths_SimdJson": Result "org.simdjson.ParseAndSelectFixPathBenchMark.parseMultiValuesForFixPaths_SimdJsonParserWithFixPath": |
e2f0def
to
4bed300
Compare
How is this different from On-Demand parsing available in the c++ simdjson version? I introduced a form of on-demand parsing in #51 (see: |
@piotrrzysko I agree with you, a DOM-like API ( Can you guide us a bit, so that we can prepare a PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@heykirby I just want share some thoughts/questions:
With some minor API changes in simdjson-java
, could we keep the SimdJsonParserWithFixPath
in another codebase or it could life in a contribution module, because it is tailored for a very specific use case?
Isn't a record JsonNode
sufficient compared to using lombok
?
ecd8e0e
to
204fed7
Compare
@piotrrzysko hello, piotrrzysko, I think the idea of reducing unused json node construction is similar with On-Demand parsing {
"statuses": [{
"text": "@aym0566x \n\n名前:前田あゆみ\n第一印象:なんか怖っ!\n今の印象:とりあえずキモい。噛み合わない\n好きなところ:ぶすでキモいとこ😋✨✨\n思い出:んーーー、ありすぎ😊❤️\nLINE交換できる?:あぁ……ごめん✋\nトプ画をみて:照れますがな😘✨\n一言:お前は一生もんのダチ💖",
"user": {
"name": "AYUMI",
"screen_name": "ayuu0123",
"followers_count": 262,
"friends_count": 252
},
"retweet_count": 0,
"favorite_count": 0
},
{
"text": "RT @KATANA77: えっそれは・・・(一同) http://t.co/PkCJAcSuYK",
"user": {
"name": "RT&ファボ魔のむっつんさっm",
"screen_name": "yuttari1998",
"followers_count": 95,
"friends_count": 158
},
"retweet_count": 82,
"favorite_count": 42
}
],
"search_metadata": {
"count": 100,
}
}
In some specific scenarios, especially big data log cleaning scenarios, it can replace the json_tuple function of hive, which may be useful. |
@arouel Thanks arouel,the unused imports has been removed |
204fed7
to
f6fc9e5
Compare
issue: #59