Skip to content

Commit

Permalink
remove version prefix
Browse files Browse the repository at this point in the history
  • Loading branch information
OzBena committed Aug 21, 2024
1 parent 801deb7 commit 7f5859f
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
6 changes: 3 additions & 3 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ The version number in `version/version.txt` follows semantic versioning:
### Versioning Workflow

1. **Updating the Version**:
- Before submitting a Pull Request (PR), update the `version.txt` file with the new version number based on the changes you are introducing (e.g., `v1.1.0` or `v1.1.0-rc1` for release candidates).
- Before submitting a Pull Request (PR), update the `version.txt` file with the new version number based on the changes you are introducing (e.g., `1.1.0` or `1.1.0-rc1` for release candidates).

2. **Committing the Version Change**:
- Commit the change to `version.txt` with a descriptive commit message following our convention.
Expand All @@ -109,9 +109,9 @@ The version number in `version/version.txt` follows semantic versioning:
- **Building and publishing binaries**.
- **Creating a new Docker image and pushing it to DockerHub**.

### Example Workflow:
### Example Workflow

1. Update `version.txt` with the new version number (e.g., `v1.1.0` or `v1.1.0-rc1`).
1. Update `version.txt` with the new version number (e.g., `1.1.0` or `1.1.0-rc1`).
2. Commit the change: `git commit -m "chore/version_Update-to-v1.1.0"`.
3. Submit a PR for review.
4. After the PR is approved and merged into `master`, the tagging workflow will automatically create a new tag (e.g., `v1.1.0`).
Expand Down
2 changes: 1 addition & 1 deletion cmd/version.go
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,6 @@ var versionCmd = &cobra.Command{
Use: "version",
Short: "Print the version number of bbox",
Run: func(cmd *cobra.Command, args []string) {
fmt.Println("bbox version:", version.GetVersion())
fmt.Printf("bbox version: v%s\n", version.GetVersion())
},
}
2 changes: 1 addition & 1 deletion version/version.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v1.0.0-rc1
1.0.0-rc1

0 comments on commit 7f5859f

Please sign in to comment.