Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/version migrate to file based versioning #6

Merged
merged 6 commits into from
Aug 21, 2024

Conversation

OzBena
Copy link
Collaborator

@OzBena OzBena commented Aug 21, 2024

Pull Request

What type of PR is this?

Maintenance

What this PR does / why we need it?

  • Added version.txt and corresponding handler. And fixed relative path issue caused by the change
  • Added workflow for static version model.
  • Fixed version handling in the Makefile.

which issue(s) this PR fixes (if exists)

Fixes #(issue)

Special notes for your reviewer

Does this PR introduce a breaking change, if so what is it?

NONE

Additional documentation


@OzBena OzBena requested a review from shayrybak August 21, 2024 12:00
@OzBena OzBena self-assigned this Aug 21, 2024
Copy link

@shayrybak shayrybak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should add the tagging procedure to the readme in contributing section

@OzBena
Copy link
Collaborator Author

OzBena commented Aug 21, 2024

we should add the tagging procedure to the readme in contributing section

I added the relevant part in the CONTRIBUTING.md

@OzBena OzBena requested a review from shayrybak August 21, 2024 13:20
Copy link

@shayrybak shayrybak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OzBena OzBena merged commit 1d0ec49 into master Aug 21, 2024
4 checks passed
@OzBena OzBena deleted the refactor/version_Migrate-to-file-based-versioning branch August 21, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants