This repository has been archived by the owner on Feb 4, 2022. It is now read-only.
Tx Information Type Tweaked to Allow for Get Tx From Hash to Return P… #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simolus3
reviewed
Dec 31, 2021
|
|
||
| /// ECDSA signature s | ||
| final BigInt s; | ||
| late final BigInt s; |
There was a problem hiding this comment.
I don't think we should make these late to indicate that they can be absent.
Instead, we could add a superclass (say RawTransactionInformation) that doesn't contain the signature. getTransactionByHash would then return a future of that class.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…roperly
@simolus3 Let me know your thoughts on this. When using getTransactionByHash() function, r, s,v from msgSig are not returned. Removed them without making them nullable in order to leave the rest of the package intact.