fix(workflow): hide idle nested subflow end handles - #6976
fix(workflow): hide idle nested subflow end handles#6976BillLeoutsakosvl346 wants to merge 3 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
8d86117 to
af79fcb
Compare
af79fcb to
f069838
Compare
f069838 to
6d0de5c
Compare
PR SummaryMedium Risk Overview Incoming edges that target a Loop/Parallel now share that container’s z-layer via Docs preview nodes now carry Reviewed by Cursor Bugbot for commit b71ba64. Configure here. |
Screen.Recording.2026-08-22.at.12.32.30.PM.mov |
Greptile SummaryThe PR hides unused visual end ports on nested Loop and Parallel containers while retaining their semantic handles, and aligns incoming-edge occlusion across editor and preview renderers.
Confidence Score: 5/5The PR appears safe to merge because no blocking failure remains within the eligible follow-up-review scope. No blocking failure remains.
|
| Filename | Overview |
|---|---|
| packages/workflow-renderer/src/subflow/subflow-node-view.tsx | Conditionally includes the fixed visual end port for nested subflows while leaving the semantic React Flow handle mounted. |
| packages/workflow-renderer/src/canvas-layers.ts | Adds shared target-aware edge layering so incoming segments are occluded by their container target. |
| apps/sim/app/workspace/[workspaceId]/w/[workflowId]/workflow.tsx | Applies target-aware layering to editor edges and their selected-edge controls. |
| apps/sim/app/workspace/[workspaceId]/w/components/preview/components/preview-workflow/preview-workflow.tsx | Applies container-target occlusion consistently in execution and application previews. |
| apps/docs/components/workflow-preview/workflow-data.ts | Computes semantic nesting depth for flattened docs nodes and applies corresponding node and edge layers. |
Reviews (3): Last reviewed commit: "perf(workflow): stabilize subflow edge s..." | Re-trigger Greptile
|
@cursor review |
|
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit b71ba64. Configure here.
Summary
Eng Todo: https://sim-ai.slack.com/archives/C093DF8MA21/p1786560718145569
Type of Change
Compatibility
Testing
Automated:
Manual local-app verification:
Checklist
Screenshots/Videos
Not attached; the manual geometry and layer verification results are listed above.