fix(imap): resolve mailbox selector contexts server-side - #7117
Closed
BillLeoutsakosvl346 wants to merge 1 commit into
Closed
fix(imap): resolve mailbox selector contexts server-side#7117BillLeoutsakosvl346 wants to merge 1 commit into
BillLeoutsakosvl346 wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
10 tasks
BillLeoutsakosvl346
force-pushed
the
fix/server-resolved-selector-context
branch
from
August 26, 2026 20:21
ad5a672 to
0b8f18c
Compare
BillLeoutsakosvl346
force-pushed
the
fix/server-resolved-imap-selectors
branch
from
August 26, 2026 20:21
b978851 to
8d4b978
Compare
BillLeoutsakosvl346
force-pushed
the
fix/server-resolved-selector-context
branch
from
August 26, 2026 22:25
fafded6 to
0486f57
Compare
BillLeoutsakosvl346
force-pushed
the
fix/server-resolved-imap-selectors
branch
from
August 26, 2026 22:25
8d4b978 to
e268ddd
Compare
BillLeoutsakosvl346
force-pushed
the
fix/server-resolved-selector-context
branch
from
August 26, 2026 23:28
0486f57 to
17726cb
Compare
BillLeoutsakosvl346
force-pushed
the
fix/server-resolved-imap-selectors
branch
from
August 26, 2026 23:28
e268ddd to
5aee4bd
Compare
BillLeoutsakosvl346
marked this pull request as ready for review
August 26, 2026 23:32
Contributor
Greptile SummaryThe PR migrates the IMAP mailbox selector to authenticated, workflow-authorized server-side context resolution.
Confidence Score: 5/5The PR appears safe to merge after its stated prerequisite PR lands and the branch is rebased and retargeted. No blocking failure remains.
|
| Filename | Overview |
|---|---|
| apps/sim/app/api/tools/imap/mailboxes/route.ts | Authenticates and authorizes the workflow before resolving, validating, and using server-only IMAP connection values. |
| apps/sim/hooks/selectors/providers/imap/selectors.ts | Marks all connection fields for server resolution and uses workflow-scoped opaque cache-key context. |
| apps/sim/lib/api/contracts/tools/imap.ts | Separates permissive wire representations from coercion and validation of resolved IMAP values. |
| apps/sim/lib/core/security/input-validation.server.ts | Adds an option to suppress sensitive host details while preserving DNS validation behavior. |
| apps/sim/app/api/tools/imap/mailboxes/server-resolved-selector.test.ts | Covers authorization ordering, context resolution, short-circuiting, sanitized failures, mailbox mapping, and cleanup. |
| apps/sim/hooks/selectors/providers/imap/server-resolved-context.test.ts | Verifies raw-reference forwarding, workflow requirements, server-resolved fields, and base-key privacy. |
| apps/sim/lib/api/contracts/tools/imap.server-resolved.test.ts | Verifies wire acceptance and resolved port and TLS coercion behavior. |
Sequence Diagram
sequenceDiagram
participant UI as IMAP Selector
participant API as Mailboxes Route
participant Auth as Selector Authorization
participant Resolver as Context Resolver
participant DNS as Host Validation
participant IMAP as IMAP Server
UI->>API: workflowId + literals/exact references
API->>Auth: Authenticate request
Auth-->>API: Authorized principal
API->>Resolver: Resolve context within workflow
Resolver-->>API: Resolved connection fields
API->>DNS: Validate and pin host
DNS-->>API: Approved IP
API->>IMAP: Connect with resolved credentials
IMAP-->>API: Mailboxes
API-->>UI: Sanitized mailbox options
Reviews (2): Last reviewed commit: "fix(imap): resolve mailbox selector cont..." | Re-trigger Greptile
BillLeoutsakosvl346
force-pushed
the
fix/server-resolved-selector-context
branch
from
August 27, 2026 00:17
17726cb to
aeaa7ec
Compare
BillLeoutsakosvl346
force-pushed
the
fix/server-resolved-imap-selectors
branch
from
August 27, 2026 00:18
5aee4bd to
4aba042
Compare
BillLeoutsakosvl346
force-pushed
the
fix/server-resolved-imap-selectors
branch
from
August 27, 2026 00:31
4aba042 to
7a86adf
Compare
Contributor
Author
Contributor
Author
|
Closing this stacked implementation while we investigate a provider-agnostic server-side selector gateway. The branches are being preserved for reference and recovery; this PR is superseded by the architecture investigation, not merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Security behavior
{{KEY}}refetches without exposing its value.Focused coverage
Verification
git diff --checkpassed on the combined stack.Browser verification