fix(slack): remove stale preview gate references - #7168
Open
TheodoreSpeaks wants to merge 1 commit into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
Greptile SummaryThis PR removes obsolete Slack preview-gate references now that Slack v2 is released and makes registry tests distinguish released Slack resolution from unrevealed Table fallback.
Confidence Score: 5/5The PR appears safe to merge because it changes only explanatory comments and targeted test expectations that match the current registry visibility and version-resolution behavior. Slack v2 is released and toolbar-visible, Table v2 remains preview-gated, and the updated tests deterministically assert those corresponding resolution paths without modifying production logic.
|
| Filename | Overview |
|---|---|
| apps/sim/app/workspace/[workspaceId]/home/components/message-content/components/special-tags/special-tags.tsx | Rewords an inline comment to describe owning-block visibility rather than the obsolete Slack preview gate; runtime behavior is unchanged. |
| apps/sim/blocks/registry-lookup.test.ts | Replaces generic parity checks with deterministic assertions for unrevealed Table fallback and released Slack v2 resolution. |
| apps/sim/blocks/registry.ts | Updates documentation to use preview-gated Table v2 as the current example; registry logic is unchanged. |
| apps/sim/lib/copilot/integration-tools.test.ts | Generalizes fixture commentary without changing test setup or expectations. |
Reviews (1): Last reviewed commit: "fix(slack): remove stale preview gate re..." | Re-trigger Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Type of Change
Testing
Checklist