Skip to content

fix(slack): remove stale preview gate references - #7168

Open
TheodoreSpeaks wants to merge 1 commit into
stagingfrom
fix/remove-block-ff
Open

fix(slack): remove stale preview gate references#7168
TheodoreSpeaks wants to merge 1 commit into
stagingfrom
fix/remove-block-ff

Conversation

@TheodoreSpeaks

Copy link
Copy Markdown
Collaborator

Summary

  • Remove stale Slack v2 preview-gate references after release
  • Cover released Slack and unrevealed Table version resolution separately

Type of Change

  • Bug fix

Testing

  • 16 targeted Vitest tests
  • Lint and block registry audit
  • 36 repository audits

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Aug 27, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Skipped Skipped Aug 27, 2026 6:03pm

Request Review

@greptile-apps

greptile-apps Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR removes obsolete Slack preview-gate references now that Slack v2 is released and makes registry tests distinguish released Slack resolution from unrevealed Table fallback.

  • Updates explanatory comments in the registry and service-account connection UI.
  • Verifies unrevealed table_v2 falls back to table.
  • Verifies released Slack resolves consistently to slack_v2.
  • Generalizes the preview-successor fixture comment in copilot integration tests.

Confidence Score: 5/5

The PR appears safe to merge because it changes only explanatory comments and targeted test expectations that match the current registry visibility and version-resolution behavior.

Slack v2 is released and toolbar-visible, Table v2 remains preview-gated, and the updated tests deterministically assert those corresponding resolution paths without modifying production logic.

Important Files Changed

Filename Overview
apps/sim/app/workspace/[workspaceId]/home/components/message-content/components/special-tags/special-tags.tsx Rewords an inline comment to describe owning-block visibility rather than the obsolete Slack preview gate; runtime behavior is unchanged.
apps/sim/blocks/registry-lookup.test.ts Replaces generic parity checks with deterministic assertions for unrevealed Table fallback and released Slack v2 resolution.
apps/sim/blocks/registry.ts Updates documentation to use preview-gated Table v2 as the current example; registry logic is unchanged.
apps/sim/lib/copilot/integration-tools.test.ts Generalizes fixture commentary without changing test setup or expectations.

Reviews (1): Last reviewed commit: "fix(slack): remove stale preview gate re..." | Re-trigger Greptile

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 4 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant