Skip to content

Fix offline recovery after reconnect - #316

Open
landeqiming666 wants to merge 1 commit into
sindresorhus:mainfrom
landeqiming666:fix-offline-recovery-state
Open

Fix offline recovery after reconnect#316
landeqiming666 wants to merge 1 commit into
sindresorhus:mainfrom
landeqiming666:fix-offline-recovery-state

Conversation

@landeqiming666

@landeqiming666 landeqiming666 commented Jun 12, 2026

Copy link
Copy Markdown

Summary

  • Restore recovery from offline state when the browser reports it is online again.
  • Keep the connection helper from staying stuck in the offline state after a transient network loss.
  • Add regression coverage for both the connection helper and background recovery path.

Validation

  • PATH=/Users/lijiaxuan/MyInformation/.local-node22/bin:$PATH npm run test:js -- test/connection-test.js test/background-test.js
  • PATH=/Users/lijiaxuan/MyInformation/.local-node22/bin:$PATH npm run lint:js
  • PATH=/Users/lijiaxuan/MyInformation/.local-node22/bin:$PATH npm run lint:css
  • PATH=/Users/lijiaxuan/MyInformation/.local-node22/bin:$PATH npm run build
  • PATH=/Users/lijiaxuan/MyInformation/.local-node22/bin:$PATH npm test
  • git diff --check

Fixes #132.


IssueHunt Summary

Referenced issues

This pull request has been submitted to:


@landeqiming666

Copy link
Copy Markdown
Author

Hi, a brief follow-up on this PR. It remains clean and mergeable, and the test check passes. The regression covers recovery after reconnecting from an offline state. Happy to adjust the state transition or coverage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Notifier stays offline despite regaining connection

1 participant