Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use @typescript-eslint/parser when react typescript #350

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: use @typescript-eslint/parser when react typescript #350

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2c38b0d
fix: use @typescript-eslint/parser when react typescript
pmjhonwang Mar 2, 2022
09217a8
fix: use @typescript-eslint/parser when root-config typescript
pmjhonwang Mar 2, 2022
058abb1
fix: use @typescript-eslint/parser when util typescript
pmjhonwang Mar 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/calm-colts-sell.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"generator-single-spa": patch
---

fix generator util typescript project use @typescript-eslint/parser as eslint parser
5 changes: 5 additions & 0 deletions .changeset/flat-buttons-wonder.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"generator-single-spa": patch
---

fix generator typescript root-config project use @typescript-eslint/parser as eslint parser
5 changes: 5 additions & 0 deletions .changeset/ten-monkeys-chew.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"generator-single-spa": patch
---

fix generator react typescript application / parcel project use @typescript-eslint/parser as eslint parser
5 changes: 5 additions & 0 deletions packages/generator-single-spa/src/react/generator-single-spa-react.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,8 +86,13 @@ module.exports = class SingleSpaReactGenerator extends PnpmGenerator {
delete packageJson.devDependencies["webpack-config-single-spa"];
// Will be replaced by webpack-config-single-spa-react-ts
delete packageJson.devDependencies["webpack-config-single-spa-ts"];
// Will be replaced by @typescript-eslint/parser
delete packageJson.devDependencies["@babel/eslint-parser"];

packageJson.types = `dist/${this.options.orgName}-${this.options.projectName}.d.ts`;
} else {
// Will be replaced by @babel/eslint-parser
delete packageJson.devDependencies["@typescript-eslint/parser"];
}

this.fs.extendJSON(this.destinationPath("package.json"), packageJson);
Expand Down
2 changes: 1 addition & 1 deletion packages/generator-single-spa/src/react/templates/.eslintrc.ejs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,5 @@
<%if (typescript) { %>"ts-react-important-stuff",<%} else { %>"react-important-stuff",<% } %>
"plugin:prettier/recommended"
],
"parser": "@babel/eslint-parser"
"parser": <%if (typescript) { %>"@typescript-eslint/parser"<%} else { %>"@babel/eslint-parser"<% } %>
}
1 change: 1 addition & 0 deletions packages/generator-single-spa/src/react/templates/react.package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
"@babel/runtime": "^7.15.3",
"@testing-library/jest-dom": "^5.14.1",
"@testing-library/react": "^12.0.0",
"@typescript-eslint/parser": "^5.13.0",
"babel-jest": "^27.0.6",
"concurrently": "^6.2.1",
"cross-env": "^7.0.3",
Expand Down
6 changes: 6 additions & 0 deletions packages/generator-single-spa/src/root-config/generator-root-config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,13 @@ module.exports = class SingleSpaRootConfigGenerator extends PnpmGenerator {
delete packageJson.devDependencies["eslint-config-important-stuff"];
// Will be replaced by webpack-config-single-spa-ts
delete packageJson.devDependencies["webpack-config-single-spa"];
// Will be replaced by @typescript-eslint/parser
delete packageJson.devDependencies["@babel/eslint-parser"];

packageJson.types = `dist/${this.options.orgName}-root-config.d.ts`;
} else {
// Will be replaced by @babel/eslint-parser
delete packageJson.devDependencies["@typescript-eslint/parser"];
}

this.fs.extendJSON(this.destinationPath("package.json"), packageJson);
Expand Down
2 changes: 1 addition & 1 deletion packages/generator-single-spa/src/root-config/templates/.eslintrc.ejs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
"extends": ["<% if (typescript) { %>ts-<% } %>important-stuff", "plugin:prettier/recommended"],
"parser": "@babel/eslint-parser"
"parser": <%if (typescript) { %>"@typescript-eslint/parser"<%} else { %>"@babel/eslint-parser"<% } %>
}
1 change: 1 addition & 0 deletions packages/generator-single-spa/src/root-config/templates/root-config.package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
"@babel/plugin-transform-runtime": "^7.15.0",
"@babel/preset-env": "^7.15.0",
"@babel/runtime": "^7.15.3",
"@typescript-eslint/parser": "^5.13.0",
"concurrently": "^6.2.1",
"cross-env": "^7.0.3",
"eslint": "^7.32.0",
Expand Down
5 changes: 5 additions & 0 deletions packages/generator-single-spa/src/util-module/generator-single-spa-util-module.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,8 +80,13 @@ module.exports = class SingleSpaUtilModuleGenerator extends PnpmGenerator {
delete packageJson.devDependencies["eslint-config-important-stuff"];
// Will be replaced by webpack-config-single-spa-ts
delete packageJson.devDependencies["webpack-config-single-spa"];
// Will be replaced by @typescript-eslint/parser
delete packageJson.devDependencies["@babel/eslint-parser"];

packageJson.types = `dist/${this.options.orgName}-${this.options.projectName}.d.ts`;
} else {
// Will be replaced by @babel/eslint-parser
delete packageJson.devDependencies["@typescript-eslint/parser"];
}

this.fs.extendJSON(this.destinationPath("package.json"), packageJson);
Expand Down
2 changes: 1 addition & 1 deletion packages/generator-single-spa/src/util-module/templates/.eslintrc.ejs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,5 @@
<%if (typescript) { %>"ts-important-stuff",<%} else { %>"important-stuff",<% } %>
"plugin:prettier/recommended"
],
"parser": "@babel/eslint-parser"
"parser": <%if (typescript) { %>"@typescript-eslint/parser"<%} else { %>"@babel/eslint-parser"<% } %>
}
1 change: 1 addition & 0 deletions packages/generator-single-spa/src/util-module/templates/util-module.package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
"@babel/plugin-transform-runtime": "^7.15.0",
"@babel/preset-env": "^7.15.0",
"@babel/runtime": "^7.15.3",
"@typescript-eslint/parser": "^5.13.0",
"babel-jest": "^27.0.6",
"concurrently": "^6.2.1",
"cross-env": "^7.0.3",
Expand Down