Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove break in get_servers #785

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

engrbm87
Copy link

Remove the break in the get_servers method so that we can get the list of servers from all urls.

Remove the break in the `get_servers` method so that we can get the list of servers from all urls.
@wriba
Copy link

wriba commented Sep 23, 2022

Thanks for submitting this. I was going to look for this exact problem. It resolves a key issue for me of not getting local area servers in the returned list.

@engrbm87
Copy link
Author

Hello @sivel , any chance we can get this merged please.

@sinnet3000
Copy link

sinnet3000 commented Apr 29, 2023

I just noticed this issue too, I was wondering why speedtest-cli was not giving as good server alternatives as in other clients and found the break, should have looked at the pull requests first lol. Hopefully can be merged.

@keithzg
Copy link

keithzg commented May 25, 2023

Just ran into this myself, was confused why two different systems and networks physically separated by only about a kilometer not only had very different lists but they also would refuse to run against server IDs not in their lists (which was making meaningful comparisons tricky!).

This line removal seems to entirely solve that, with many more servers now listed and reachable, although I note that the list shown via --list now has most (though fascinatingly not all) entries duplicated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants