Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add foreach Functionality for DataFrame Operations #20

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions src/dataframe.rs
Original file line number Diff line number Diff line change
Expand Up @@ -210,6 +210,17 @@ impl DataFrame {

Ok(data.value(0))
}
pub async fn foreach<F>(self, mut f: F) -> Result<(), SparkError>
where
F: FnMut(&RecordBatch) -> (),
{
let rows = self.collect().await?;
for i in 0..rows.num_rows() {
let row = rows.slice(i, 1);
f(&row);
}
Ok(())
}

/// Creates a local temporary view with this DataFrame.
#[allow(non_snake_case)]
Expand Down
25 changes: 25 additions & 0 deletions src/functions/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -528,6 +528,31 @@ mod tests {
assert_eq!(&expected, &rows_func_asc);
Ok(())
}
#[tokio::test]
async fn test_func_foreach() -> Result<(), SparkError> {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we move this test into the dataframe.rs file?

let spark = setup().await;

let df_col_asc = spark
.clone()
.range(Some(1), 4, 1, Some(1))
.sort([col("id").desc()]);

let mut result = Vec::new();
let capture_result = |row: &RecordBatch| {
result.push(row.clone());
};

df_col_asc.foreach(capture_result).await?;

assert_eq!(result.len(), 3);

assert_eq!(result[0].column(0).as_any().downcast_ref::<Int64Array>().unwrap().value(0), 3);
assert_eq!(result[1].column(0).as_any().downcast_ref::<Int64Array>().unwrap().value(0), 2);
assert_eq!(result[2].column(0).as_any().downcast_ref::<Int64Array>().unwrap().value(0), 1);

Ok(())
}


#[tokio::test]
async fn test_func_desc() -> Result<(), SparkError> {
Expand Down