Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[22438] Ticket caching fix #464

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

MichaelReyes
Copy link
Collaborator

Pull Request (PR) Checklist

Thank you for your contribution! Please confirm that you've checked all the boxes below before submitting your PR. Use [x] to check a box, e.g., [x], and make sure there's no space around the brackets.

PR Context

Changes

Describe your changes in detail, highlighting the problem it solves or the feature it adds.

  • [TripKit] update QuickBooking and QuickBookingRepository to include userId on caching and fetching ticket from cache.
  • [TripKit] update TicketDao to add queries with userId for saving and fetching tickets
  • [TripKit] update TicketEntity to add field for userId and TripKitDatabase add migration for db to alter table and add the userid field.
  • [TripGo] update TransitTicketItem to fetch and pass userId when calling getTickets from QuickBookingRepository

Checklist for Reviewers

Documentation and Code Quality

  • KDocs Documentation: Are all changes, new functionalities, and classes documented with KDocs?
  • Architectural Patterns: Is there consistent and proper use of architectural patterns (e.g., MVVM, MVP)?

Testing and Reliability

  • Unit Testing: Are there unit tests for all new functionalities and classes?
  • Emulator and Real Device Testing: Has the application been tested on both emulators and real devices to ensure compatibility?

Error Handling and Logging

  • Error Handling: Are errors and exceptions caught and handled gracefully, ensuring the app remains stable?
  • Logging: Is there proper logging in place for critical errors and information, aiding in debugging and monitoring?

Testing Procedure

If applicable, provide steps or commands for testing your changes. This can help reviewers and testers.

Work-in-Progress (WIP)

List any remaining work or areas that need additional focus. This section can be updated as the work progresses.

  • [ ]
  • [ ]

Remember to keep this template updated based on the feedback and evolving project standards.

- [TripKit] update QuickBooking and QuickBookingRepository to include userId on caching and fetching ticket from cache.
- [TripKit] update TicketDao to add queries with userId for saving and fetching tickets
- [TripKit] update TicketEntity to add field for userId and TripKitDatabase add migration for db to alter table and add the userid field.
- [TripGo] update TransitTicketItem to fetch and pass userId when calling getTickets from QuickBookingRepository
@MichaelReyes MichaelReyes changed the title [22438] [22438] Ticket caching fix Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants