Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make items of options parameter optional #96

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lakson
Copy link

@lakson lakson commented Jul 25, 2021

issue: options not working with Angular 11 #91

i make all variables of options class optionnal by adding ? behind

@ejazpacheco
Copy link

@lakson , my fear here would be if there was some conflict and package-lock and node_modeles are removed it will cause an issue. This worked like a charm.

import { Options } from 'ngx-google-places-autocomplete/objects/options/options';

options = {
componentRestrictions: { country: ['ca'] }
} as unknown as Options;

@dancornilov
Copy link

This thing was adjusted in new package, in general class was omitted and used interface instead. Because of inactivity of this package, I created my own package which is fully compatible with this one, code base was used from this package and adjusted to new coding standards.

You can try:
https://www.npmjs.com/package/@angular-magic/ngx-gp-autocomplete

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants