Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Tian Xia <cblmemo@gmail.com>
  • Loading branch information
andylizf and cblmemo authored Nov 3, 2024
1 parent e7d99d4 commit 79a8089
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion sky/jobs/controller.py
Original file line number Diff line number Diff line change
Expand Up @@ -439,7 +439,7 @@ def _cancel_all_tasks(self, task_id: int) -> None:
def run(self) -> None:
"""Run controller logic and handle exceptions."""
all_tasks_completed = lambda: self._num_tasks == len(self._task_status)
# TODO(andy):Serve has a logic to prevent from too many services running
# TODO(andy): Serve has a logic to prevent from too many services running
# at the same time. We should have a similar logic here, but instead we
# should calculate the sum of the subtasks (an upper bound), instead of
# the number of jobs (dags).
Expand Down

0 comments on commit 79a8089

Please sign in to comment.