Skip to content

Commit

Permalink
Remove version upper bound on pyyaml (#2514)
Browse files Browse the repository at this point in the history
* Remove version upper bound on `pyyaml`

* Disallow `5.4.*` due to incompatibility with cython3

Co-authored-by: Romil Bhardwaj <romil.bhardwaj@gmail.com>

* Update comment for PyYAML pinned versions

---------

Co-authored-by: Romil Bhardwaj <romil.bhardwaj@gmail.com>
  • Loading branch information
steve-marmalade and romilbhardwaj authored Sep 6, 2023
1 parent a8100f4 commit 7d59ff9
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions sky/setup_files/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -109,11 +109,9 @@ def parse_readme(readme: str) -> str:
# >=1.10.8 is needed for ray>=2.6. See
# https://github.com/ray-project/ray/issues/35661
'pydantic <2.0, >=1.10.8',
# Cython 3.0 release breaks PyYAML installed by aws-cli.
# https://github.com/yaml/pyyaml/issues/601
# https://github.com/aws/aws-cli/issues/8036
# Cython 3.0 release breaks PyYAML 5.4.* (https://github.com/yaml/pyyaml/issues/601)
# <= 3.13 may encounter https://github.com/ultralytics/yolov5/issues/414
'pyyaml > 3.13, <= 5.3.1'
'pyyaml > 3.13, != 5.4.*'
]

# NOTE: Change the templates/spot-controller.yaml.j2 file if any of the
Expand Down

0 comments on commit 7d59ff9

Please sign in to comment.