Default to ubuntu for GCP and avoid key pair checking #1641

Michaelvll · 2023-01-27T20:26:52Z

Prerequisite: skypilot-org/skypilot-catalog#25

Main changes:

Have GCP default to ubuntu image instead of Debian to fix Python version mismatch when migrating from AWS to GCP #1604
Fix the ssh connection issue caused by control master for GCP with ubuntu image
Before the fix, the ssh connection will be disconnected when ray trying to setup the runtime dependencies, which is probably because the ssh connection is unstable when the cluster is just provisioned [autoscaler][gcp] "ray up" on GCP isn't working ray-project/ray#16539 (comment). We added retry for the ssh commands executed by ray up, which is ok since our setup commands are idempotent.
Refactor the authentication
Use the cloud-init to setup the key pairs for GCP, to avoid the permissions to check the key_pairs.
Use the cloud-init to disable the apt unattended-upgrade, to avoid the lock for apt install (Note: cloud-init is not installed on debian image, so we could not do it for our previous debian image)

This PR may cause some backward compatibility issue for GCP user who created images from our previous debian-based image, as the cloud-init is not installed on those images. Trying to fix that now. It should now be fixed.

A good thing about the new image is that the ray==2.4.0 is installed by default in the image, the provision time would be faster if #1734 is merged.

Tested (run the relevant ones):

sky launch --cloud gcp --gpus t4 test.yaml

setup: |
  echo "setup"
  for i in `seq 1 10000000`; do
    echo $i
    sleep 1
  done

sky launch --cloud gcp --gpus k80 test.yaml

setup: |
  echo "setup"
  for i in `seq 1 10000000`; do
    echo $i
    sleep 1
  done

sky launch -c test-new-image-1 --cloud gcp echo hi
sky launch -c test-old-image --cloud gcp echo hi --image-id projects/deeplearning-platform-release/global/images/common-cpu-v20221215
for i in seq 5; do pytest tests/test_smoke.py::test_cancel_pytorch --terminate-on-failure; done makes sure that the wait time is enough (the magic number in the head_start_ray_commands)
All smoke tests: pytest tests/test_smoke.py
pytest tests/test_smoke.py --aws
Backward compatibility tests: bash tests/backward_comaptibility_tests.sh

Michaelvll · 2023-02-01T03:55:36Z

The deep learning ubuntu image on GCP does not work well, as the ssh connection will be disconnected when the VM is firstly booted. Here are several things we have tried:

The ubuntu-os-cloud image does not have the problem, but it does not have the NVIDIA driver installed. We have to install it ourselves (here), which will take a while.
Changing the ServerAliveInternal and ClientAliveInterval does not work well, i.e. the cluster will still be disconnected.
Removing the control path helps a bit with the disconnection problem, but the problem still exists and it will make the ssh slower
Adding retry for the ssh command runner for ray will help the ray up, but the ssh commands by our SkyPilot could still fail due to the same disconnection issue.

Due to the investigation above, we decided to defer this PR and probably host our own image in the future instead (e.g. we can create an image based on the ubuntu-os-cloud).

Michaelvll · 2023-05-10T02:40:27Z

Just figured out that the interruption of the ssh was caused by the async installation of the nvidia-driver, which will restart the server after it finishes. We now wait for the nvidia-driver to be installed before start running the user's program, and it works.

use ubuntu fix Disable control master for GCP fix test no control master and longer alive interval retry run command runner with retry add sleep retry for ray status Longer timeout avoid control persist format set ClientAliveInterval revert command runner revert command_runner fix ssh disconnection issue format fallback to debian for K80 fix k80 Backward compatibility for old debian based images minor fix Fix TPU VM add clientaliveinterval add markers for specific clouds uninstall before install uninstall -y azure uninstall longer wait time remove apt related setting fix ssh name

concretevitamin

Thanks @Michaelvll! Still need to read the PR. But I just tried it out with a previously launched & autostopped GCP controller, and got:

» sky spot launch echo hi --cloud gcp
...
I 05-14 09:33:18 cloud_vm_ray_backend.py:1033] Cluster 'sky-spot-controller-8a3968f2' (status: STOPPED) was previously launched in GCP us-central1. Relaunching in that region.
...

  File "/Users/zongheng/Dropbox/workspace/riselab/sky-computing/sky/backends/cloud_vm_ray_backend.py", line 1259, in _retry_zones
    keep_launch_fields_in_existing_config=cluster_exists)
  File "/Users/zongheng/Dropbox/workspace/riselab/sky-computing/sky/utils/common_utils.py", line 241, in _record
    return f(*args, **kwargs)
  File "/Users/zongheng/Dropbox/workspace/riselab/sky-computing/sky/backends/backend_utils.py", line 797, in write_cluster_config
    to_provision, region, zones)
  File "/Users/zongheng/Dropbox/workspace/riselab/sky-computing/sky/clouds/gcp.py", line 356, in make_deploy_resources_variables
    assert image_id is not None, (image_id, r)
AssertionError: (None, GCP(n2-standard-4, disk_size=50))

concretevitamin · 2023-05-14T16:32:22Z

sky/templates/aws-ray.yml.j2

@@ -177,7 +177,7 @@ setup_commands:
    (type -a pip | grep -q pip3) || echo 'alias pip=pip3' >> ~/.bashrc;
    (which conda > /dev/null 2>&1 && conda init > /dev/null) || (wget -nc https://repo.anaconda.com/miniconda/Miniconda3-latest-Linux-x86_64.sh && bash Miniconda3-latest-Linux-x86_64.sh -b && eval "$(~/miniconda3/bin/conda shell.bash hook)" && conda init && conda config --set auto_activate_base true);
    source ~/.bashrc;
-    (pip3 list | grep ray | grep {{ray_version}} 2>&1 > /dev/null || pip3 install -U ray[default]=={{ray_version}}) && mkdir -p ~/sky_workdir && mkdir -p ~/.sky/sky_app;
+    (pip3 list | grep ray | grep {{ray_version}} 2>&1 > /dev/null || pip3 uninstall -y ray ray-cpp && pip3 install -U ray[default]=={{ray_version}}) && mkdir -p ~/sky_workdir && mkdir -p ~/.sky/sky_app;


Q: since we do a grep ray ... || ..., this means ray is not found. Why is pip3 uninstall necessary? Why add ray-cpp?

We use the grep {{ray_version}} to check the correct ray version is installed on the remote VM. It is possible that ray with another version is pre-installed on the VM. For example, the ubuntu image on GCP has the ray==2.4.0 installed, which will cause pip problem if we directly pip install -U ray[default]==2.0.1 (causing the ray package corrupted.)

Nice! Can we copy this comment into the j2 files? Something like "Ensure only one Ray version (which is our ray_version) is installed, regardless of if the image comes pre-installed with another Ray version."

concretevitamin · 2023-05-14T16:34:48Z

sky/clouds/gcp.py

        # We use the debian image, as the ubuntu image has some connectivity
        # issue when first booted.


Since we are using ubuntu image now, we use grep ubuntu-2004 to find the correct images.

Sorry, meant that

# We use the debian image, as the ubuntu image has some connectivity # issue when first booted.

could be removed.

Ahh, good catch! Removed. Thanks!

Michaelvll

Thanks @concretevitamin! This PR requires the PR for adding the ubuntu image in GCP catalog skypilot-org/skypilot-catalog#25. I am planning to increase the version number of the catalog, to make sure users will download the latest catalog automatically to avoid the issue of staled catalog.

Michaelvll · 2023-05-14T18:08:35Z

sky/clouds/gcp.py

        # We use the debian image, as the ubuntu image has some connectivity
        # issue when first booted.


Since we are using ubuntu image now, we use grep ubuntu-2004 to find the correct images.

Michaelvll · 2023-05-14T18:12:27Z

sky/templates/aws-ray.yml.j2

@@ -177,7 +177,7 @@ setup_commands:
    (type -a pip | grep -q pip3) || echo 'alias pip=pip3' >> ~/.bashrc;
    (which conda > /dev/null 2>&1 && conda init > /dev/null) || (wget -nc https://repo.anaconda.com/miniconda/Miniconda3-latest-Linux-x86_64.sh && bash Miniconda3-latest-Linux-x86_64.sh -b && eval "$(~/miniconda3/bin/conda shell.bash hook)" && conda init && conda config --set auto_activate_base true);
    source ~/.bashrc;
-    (pip3 list | grep ray | grep {{ray_version}} 2>&1 > /dev/null || pip3 install -U ray[default]=={{ray_version}}) && mkdir -p ~/sky_workdir && mkdir -p ~/.sky/sky_app;
+    (pip3 list | grep ray | grep {{ray_version}} 2>&1 > /dev/null || pip3 uninstall -y ray ray-cpp && pip3 install -U ray[default]=={{ray_version}}) && mkdir -p ~/sky_workdir && mkdir -p ~/.sky/sky_app;


We use the grep {{ray_version}} to check the correct ray version is installed on the remote VM. It is possible that ray with another version is pre-installed on the VM. For example, the ubuntu image on GCP has the ray==2.4.0 installed, which will cause pip problem if we directly pip install -U ray[default]==2.0.1 (causing the ray package corrupted.)

concretevitamin

Some comments, haven't got the chance to test it due to the V6 catalog.

sky/authentication.py

concretevitamin · 2023-05-14T21:52:12Z

sky/clouds/gcp.py

-        if image_id.startswith('skypilot:'):
-            return DEFAULT_GCP_IMAGE_GB
+    @classmethod
+    def get_image_infos(cls, image_id) -> Dict[str, Any]:


nit: get_image_info() and s/infos/info elsewhere?

concretevitamin · 2023-05-14T21:53:44Z

sky/clouds/gcp.py

+    def get_image_size(self, image_id: str, region: Optional[str]) -> float:
+        del region  # unused
+        if image_id.startswith('skypilot:'):
+            return DEFAULT_GCP_IMAGE_GB


Q: how do we guarantee that the ubuntu & debian tags have the same size, DEFAULT_GCP_IMAGE_GB?

The image size can be got using gcloud compute images describe projects/deeplearning-platform-release/global/images/common-cu113-v20230501-ubuntu-2004-py37, and it seems both of them have the same size of 50GB. Added a comment for the hack.

concretevitamin · 2023-05-14T21:55:09Z

sky/clouds/gcp.py

+        if 'diskSizeGb' not in image_infos:
+            return DEFAULT_GCP_IMAGE_GB


I'm reading get_image_size() for the first time and this seems a bit unclear. If user passes in a custom image that does not have diskSizeGb, returning a default 50GB seems like a guess (maybe ok), rather than we the func name suggests.

All the images should have that field, but this is just a safeguard to avoid the function raising the error, as the image size check is not critical. Added a comment.

concretevitamin · 2023-05-14T21:55:32Z

sky/clouds/gcp.py

        # We use the debian image, as the ubuntu image has some connectivity
        # issue when first booted.


Sorry, meant that

# We use the debian image, as the ubuntu image has some connectivity # issue when first booted.

could be removed.

sky/templates/gcp-ray.yml.j2

concretevitamin · 2023-05-14T22:58:21Z

sky/templates/gcp-ray.yml.j2

@@ -170,8 +218,8 @@ setup_commands:
    test -f /home/gcpuser/miniconda3/etc/profile.d/conda.sh && source /home/gcpuser/miniconda3/etc/profile.d/conda.sh && conda activate base || true;
    pip3 install --upgrade google-api-python-client;
  {%- endif %}
-    (pip3 list | grep ray | grep {{ray_version}} 2>&1 > /dev/null || pip3 install -U ray[default]=={{ray_version}}) && mkdir -p ~/sky_workdir && mkdir -p ~/.sky/sky_app;
-    (pip3 list | grep skypilot && [ "$(cat {{sky_remote_path}}/current_sky_wheel_hash)" == "{{sky_wheel_hash}}" ]) || (pip3 uninstall skypilot -y; pip3 install "$(echo {{sky_remote_path}}/{{sky_wheel_hash}}/skypilot-{{sky_version}}*.whl)[gcp]" && echo "{{sky_wheel_hash}}" > {{sky_remote_path}}/current_sky_wheel_hash || exit 1);
+    (pip3 list | grep ray | grep {{ray_version}} 2>&1 > /dev/null && python3 -c "import ray" || pip3 uninstall -y ray ray-cpp && pip3 install -U ray[default]=={{ray_version}}) && mkdir -p ~/sky_workdir && mkdir -p ~/.sky/sky_app;


Q: GCP j2 has an extra "python3 -c "import ray" vs. other j2's. Any reason?

That is because the reboot caused by the nvidia-driver installation can cause the pip install interrupted during execution, leading to a corrupted installation of ray. The python3 -c "import ray" is to check the integrity of the ray package installation. Added a comment above. Thanks!

concretevitamin · 2023-05-14T23:00:28Z

sky/templates/gcp-ray.yml.j2

+    # Magic number for waiting the nvidia driver to be ready and the instance
+    # to be rebooted.
+    sleep 18


Suggested change

# Magic number for waiting the nvidia driver to be ready and the instance

# to be rebooted.

sleep 18

# Magic number for waiting for the nvidia driver to be ready and the instance

# to be rebooted.

sleep 18

By magic number, do you mean it's arbitrarily chosen?

Ahh, sorry for the confusion. The number was chosen by binary search, finding the smallest number that will make sure the ssh connection issue not happens for the later commands.

sky/templates/gcp-ray.yml.j2

concretevitamin · 2023-05-14T23:01:13Z

sky/templates/gcp-ray.yml.j2

 head_start_ray_commands:
  # Start skylet daemon. (Should not place it in the head_setup_commands, otherwise it will run before sky is installed.)
  # NOTE: --disable-usage-stats in `ray start` saves 10 seconds of idle wait.
  # Line "which prlimit ..": increase the limit of the number of open files for the raylet process, as the `ulimit` may not take effect at this point, because it requires
  # all the sessions to be reloaded. This is a workaround.
+{%- if gpu is not none %}
+  - |
+    echo "Installing NVIDIA GPU driver." >> ~/.sky/nvlog


Is the reason we need to do this some peculiarities of the ubuntu image?

Yes, the reason we need this is that for the ubuntu image, after the nvidia-driver is installed, the machine will be rebooted, causing the ssh connection issue for the later user script, and the ray cluster not existing problem. We have this here to make sure the reboot is finished before we proceed to the next stages.

Michaelvll

Just realized I have some pending comments. Will merge the master branch and test this PR with smoke test again:

pytest tests/test_smoke.py

sky/authentication.py

Michaelvll · 2023-05-15T04:39:38Z

sky/clouds/gcp.py

+    def get_image_size(self, image_id: str, region: Optional[str]) -> float:
+        del region  # unused
+        if image_id.startswith('skypilot:'):
+            return DEFAULT_GCP_IMAGE_GB


The image size can be got using gcloud compute images describe projects/deeplearning-platform-release/global/images/common-cu113-v20230501-ubuntu-2004-py37, and it seems both of them have the same size of 50GB. Added a comment for the hack.

Michaelvll · 2023-05-15T04:42:32Z

sky/clouds/gcp.py

+        if 'diskSizeGb' not in image_infos:
+            return DEFAULT_GCP_IMAGE_GB


All the images should have that field, but this is just a safeguard to avoid the function raising the error, as the image size check is not critical. Added a comment.

Michaelvll · 2023-05-15T04:43:04Z

sky/clouds/gcp.py

        # We use the debian image, as the ubuntu image has some connectivity
        # issue when first booted.


Ahh, good catch! Removed. Thanks!

sky/clouds/gcp.py

Michaelvll · 2023-05-15T05:09:35Z

sky/templates/gcp-ray.yml.j2

 head_start_ray_commands:
  # Start skylet daemon. (Should not place it in the head_setup_commands, otherwise it will run before sky is installed.)
  # NOTE: --disable-usage-stats in `ray start` saves 10 seconds of idle wait.
  # Line "which prlimit ..": increase the limit of the number of open files for the raylet process, as the `ulimit` may not take effect at this point, because it requires
  # all the sessions to be reloaded. This is a workaround.
+{%- if gpu is not none %}
+  - |
+    echo "Installing NVIDIA GPU driver." >> ~/.sky/nvlog


Yes, the reason we need this is that for the ubuntu image, after the nvidia-driver is installed, the machine will be rebooted, causing the ssh connection issue for the later user script, and the ray cluster not existing problem. We have this here to make sure the reboot is finished before we proceed to the next stages.

Michaelvll · 2023-05-15T05:10:28Z

sky/templates/gcp-ray.yml.j2

+    # Magic number for waiting the nvidia driver to be ready and the instance
+    # to be rebooted.
+    sleep 18


Ahh, sorry for the confusion. The number was chosen by binary search, finding the smallest number that will make sure the ssh connection issue not happens for the later commands.

sky/templates/gcp-ray.yml.j2

Michaelvll · 2023-05-15T05:13:12Z

sky/templates/gcp-ray.yml.j2

  {%- if gpu is not none %}
+    {%- if 'tesla-k80' in gpu %}


Ahh, good catch! It should be if... else. Will run the tests again.

Michaelvll · 2023-05-15T05:23:08Z

sky/templates/gcp-ray.yml.j2

+                - path: /etc/ssh/sshd_config
+                  append: true
+                  content: |
+                    ClientAliveInterval 720
+                    ClientAliveCountMax 720


Ahh, that is a remnant. Just tested it again without it, and it seems working well. Removed. Thanks!

…init

cblmemo

Thanks for adding this feature! 🚀 Just went through the code and it looks good to me except for some minor details. Left some comments here:

sky/authentication.py

cblmemo · 2023-07-10T21:18:13Z

sky/skylet/providers/gcp/node_provider.py

+            SSHCommandRunner,
+        )
+
+        class SSHCommandRunnerWithRetry(SSHCommandRunner):


Maybe consider moving this to sky/skylet/providers/command_runner.py after #1910 is merged?

cblmemo · 2023-07-10T21:23:11Z

sky/clouds/service_catalog/gcp_catalog.py

+if _image_df[_image_df['Tag'] == 'skypilot:cpu-ubuntu-2004'].empty:
+    # Update the image catalog if it does not include the updated images
+    # https://github.com/skypilot-org/skypilot-catalog/pull/25.
+    _image_df = common.read_catalog('gcp/images.csv', pull_frequency_hours=0)


Just to make sure, after increasing our version number, we don't need this right?

cblmemo · 2023-07-10T21:27:53Z

sky/templates/aws-ray.yml.j2

@@ -187,7 +186,7 @@ setup_commands:
    (type -a pip | grep -q pip3) || echo 'alias pip=pip3' >> ~/.bashrc;
    (which conda > /dev/null 2>&1 && conda init > /dev/null) || (wget -nc https://repo.anaconda.com/miniconda/Miniconda3-latest-Linux-x86_64.sh && bash Miniconda3-latest-Linux-x86_64.sh -b && eval "$(~/miniconda3/bin/conda shell.bash hook)" && conda init && conda config --set auto_activate_base true);
    source ~/.bashrc;
-    (pip3 list | grep "ray " | grep {{ray_version}} 2>&1 > /dev/null || pip3 install --exists-action w -U ray[default]=={{ray_version}}) && mkdir -p ~/sky_workdir && mkdir -p ~/.sky/sky_app;
+    (pip3 list | grep "ray " | grep {{ray_version}} 2>&1 > /dev/null || pip3 uninstall -y ray ray-cpp && pip3 install --exists-action w -U ray[default]=={{ray_version}}) && mkdir -p ~/sky_workdir && mkdir -p ~/.sky/sky_app;


Shall we add a comment like sky/templates/gcp-ray.yml.j2, L192?

cblmemo · 2023-07-10T21:27:59Z

sky/templates/azure-ray.yml.j2

@@ -126,7 +126,7 @@ setup_commands:
    (type -a pip | grep -q pip3) || echo 'alias pip=pip3' >> ~/.bashrc;
    which conda > /dev/null 2>&1 || (wget -nc https://repo.anaconda.com/miniconda/Miniconda3-latest-Linux-x86_64.sh && bash Miniconda3-latest-Linux-x86_64.sh -b && eval "$(/home/azureuser/miniconda3/bin/conda shell.bash hook)" && conda init && conda config --set auto_activate_base true);
    source ~/.bashrc;
-    (pip3 list | grep "ray " | grep {{ray_version}} 2>&1 > /dev/null || pip3 install --exists-action w -U ray[default]=={{ray_version}}) && mkdir -p ~/sky_workdir && mkdir -p ~/.sky/sky_app && touch ~/.sudo_as_admin_successful;
+    (pip3 list | grep "ray " | grep {{ray_version}} 2>&1 > /dev/null || pip3 uninstall -y ray ray-cpp && pip3 install --exists-action w -U ray[default]=={{ray_version}}) && mkdir -p ~/sky_workdir && mkdir -p ~/.sky/sky_app && touch ~/.sudo_as_admin_successful;


Same as before

cblmemo · 2023-07-10T21:29:50Z

sky/templates/gcp-ray.yml.j2

-    (pip3 list | grep "ray " | grep {{ray_version}} 2>&1 > /dev/null || pip3 install --exists-action w -U ray[default]=={{ray_version}}) && mkdir -p ~/sky_workdir && mkdir -p ~/.sky/sky_app;
-    (pip3 list | grep "skypilot " && [ "$(cat {{sky_remote_path}}/current_sky_wheel_hash)" == "{{sky_wheel_hash}}" ]) || (pip3 uninstall skypilot -y; pip3 install "$(echo {{sky_remote_path}}/{{sky_wheel_hash}}/skypilot-{{sky_version}}*.whl)[gcp]" && echo "{{sky_wheel_hash}}" > {{sky_remote_path}}/current_sky_wheel_hash || exit 1);
+    (pip3 list | grep "ray " | grep {{ray_version}} 2>&1 > /dev/null && python3 -c "import ray" || pip3 uninstall -y ray ray-cpp && pip3 install --exists-action w -U ray[default]=={{ray_version}}) && mkdir -p ~/sky_workdir && mkdir -p ~/.sky/sky_app;
+    (pip3 list | grep "skypilot " && [ "$(cat {{sky_remote_path}}/current_sky_wheel_hash)" == "{{sky_wheel_hash}}" ]) && python3 -c "import sky" || (pip3 uninstall skypilot -y; pip3 install "$(echo {{sky_remote_path}}/{{sky_wheel_hash}}/skypilot-{{sky_version}}*.whl)[gcp]" && echo "{{sky_wheel_hash}}" > {{sky_remote_path}}/current_sky_wheel_hash || exit 1);


Why do we need import ray here? IIUC ray with correct version is installed in L211?

github-actions · 2023-11-08T02:03:09Z

This PR is stale because it has been open 120 days with no activity. Remove stale label or comment or this will be closed in 10 days.

github-actions · 2023-11-18T02:05:06Z

This PR was closed because it has been stalled for 10 days with no activity.

Michaelvll marked this pull request as draft January 27, 2023 23:29

Michaelvll added the deferred label Feb 1, 2023

Michaelvll marked this pull request as ready for review May 10, 2023 02:39

Michaelvll removed the deferred label May 10, 2023

Michaelvll requested a review from concretevitamin May 10, 2023 03:45

This was referenced May 10, 2023

Add ubuntu image for GCP skypilot-org/skypilot-catalog#25

Open

[AWS] Disable unattended-upgrade with cloud-init #1949

Merged

Michaelvll force-pushed the cloud-init branch 3 times, most recently from 8d67b5f to 8aed703 Compare May 12, 2023 19:08

Michaelvll added 6 commits May 12, 2023 16:27

Use file based apt update disabling

685327e

Add ssh config

289db1e

Add magic number for waiting

17e35b2

format

3f86961

uninstall ray-cpp as well

f4507bb

Michaelvll force-pushed the cloud-init branch from 6e68037 to f4507bb Compare May 12, 2023 23:27

Michaelvll added 2 commits May 12, 2023 16:36

check the corrupted installation

d1cc352

increase the timeout

56b925f

concretevitamin reviewed May 14, 2023

View reviewed changes

Michaelvll commented May 14, 2023

View reviewed changes

This comment was marked as duplicate.

Sign in to view

increase catalog version

ccd7365

concretevitamin reviewed May 14, 2023

View reviewed changes

Michaelvll added 3 commits May 14, 2023 22:13

Address comments

f5c2044

longer time for job queue

31f906a

format

fcf05ec

Michaelvll commented May 26, 2023

View reviewed changes

Michaelvll added 4 commits June 21, 2023 17:22

Merge branch 'master' of github.com:skypilot-org/skypilot into cloud-…

0985954

…init

Merge branch 'master' of github.com:skypilot-org/skypilot into cloud-…

66d7dbb

…init

adopt gcp official way to set ssh key

2e871e7

autoupdate images.csv

f85b4f3

cblmemo mentioned this pull request Jul 10, 2023

[WIP] Support Cloud-Init in GCP #2209

Closed

5 tasks

cblmemo reviewed Jul 10, 2023

View reviewed changes

cblmemo mentioned this pull request Jul 16, 2023

Add error message for rsync not found in image #2250

Merged

5 tasks

github-actions bot added the Stale label Nov 8, 2023

github-actions bot closed this Nov 18, 2023

		# We use the debian image, as the ubuntu image has some connectivity
		# issue when first booted.

		if 'diskSizeGb' not in image_infos:
		return DEFAULT_GCP_IMAGE_GB

Default to ubuntu for GCP and avoid key pair checking #1641

Default to ubuntu for GCP and avoid key pair checking #1641

Conversation

Michaelvll commented Jan 27, 2023 • edited Loading

Michaelvll commented Feb 1, 2023

Michaelvll commented May 10, 2023 • edited Loading

concretevitamin left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Michaelvll left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

This comment was marked as duplicate.

concretevitamin left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Michaelvll left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cblmemo left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Nov 8, 2023

github-actions bot commented Nov 18, 2023

Michaelvll commented Jan 27, 2023 •

edited

Loading

Michaelvll commented May 10, 2023 •

edited

Loading

Michaelvll left a comment •

edited

Loading

cblmemo left a comment •

edited

Loading