-
Notifications
You must be signed in to change notification settings - Fork 501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Azure] Allow resource group specifiation for Azure instance provisioning #3764
[Azure] Allow resource group specifiation for Azure instance provisioning #3764
Conversation
@landscapepainter if we plan to get this in for 0.7, can we resolve merge conflicts so we can start reviewing? |
@yika-luo @michaelzhiluo Merged the master branch and re-ran smoke and manul tests as there were large changes from the master branch. This is ready for a look! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the thorough testing!
…ning (#3764) * Allow resource group specifiation for Azure instance provisioning * Add 'use_external_resource_group' under provider config * nit * attached resources deletion * support deployment removal when terminating * nit * delete RoleAssignment when terminating * update ARM config template * nit * nit * delete role assignment with guid * update role assignment removal logic * Separate resource group region and VM, attached resources * nit * nit * nit * nit * add error handling for deletion * format * deployment naming update * test * nit * update deployment constant names * update open_ports to wait for the nsg creation corresponding to the VM being provisioned * format * nit * format * update docstring * add back deleted snippet * format * delete nic with retries * error handle update
This resolves #3659
Tested (run the relevant ones):
bash format.sh
storage_account
along withresource_group_vm
both specified at~/.sky/config.yaml
config.yaml
and remove Asky serve up
is created at the specified resource group.pytest tests/test_smoke.py
pytest tests/test_smoke.py --azure
except:tests/test_smoke.py::test_cancel_pytorch
pytest tests/test_smoke.py::test_fill_in_the_name
resource_group_vm
specified