-
Notifications
You must be signed in to change notification settings - Fork 501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[k8s] Show all kubernetes clusters in optimizer table #4013
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Michaelvll! Tested on GKE + local cluster, works well.
'use_spot': resources.use_spot | ||
} | ||
if isinstance(resources.cloud, clouds.Kubernetes): | ||
resource_key_dict['region'] = resources.region |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a quick comment here describing why we add region
here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point! Added.
Should we merge this @Michaelvll? |
Oops, missed the review. Will merge it soon |
…ulti-k8s-contexts-in-optimizer
Since we support multiple k8s clusters, people may expect to see multiple k8s clusters in their
allowed_contexts
that have the available GPUs.Two clusters:
Tested (run the relevant ones):
bash format.sh
pytest tests/test_smoke.py
pytest tests/test_smoke.py::test_fill_in_the_name
conda deactivate; bash -i tests/backward_compatibility_tests.sh