Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[k8s] Add retry for apparmor failures #4176

Merged
merged 2 commits into from
Oct 25, 2024
Merged

[k8s] Add retry for apparmor failures #4176

merged 2 commits into from
Oct 25, 2024

Conversation

romilbhardwaj
Copy link
Collaborator

Closes #4174.

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • Any manual or new tests for this PR (please specify below)
  • All smoke tests: pytest tests/test_smoke.py
  • Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
  • Backward compatibility tests: conda deactivate; bash -i tests/backward_compatibility_tests.sh

Michaelvll
Michaelvll approved these changes Oct 25, 2024
View reviewed changes
Copy link
Collaborator

@Michaelvll Michaelvll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this @romilbhardwaj! LGTM.

sky/provision/kubernetes/instance.py Show resolved Hide resolved
@romilbhardwaj romilbhardwaj added this pull request to the merge queue Oct 25, 2024
Merged via the queue into master with commit bbf14d5 Oct 25, 2024
20 checks passed
@romilbhardwaj romilbhardwaj deleted the k8s_fix_apparmor branch October 25, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Michaelvll Michaelvll Michaelvll approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[k8s] Using AppArmor causes provisioning failures on certain k8s clusters
2 participants
@romilbhardwaj @Michaelvll