[dev] restrict pylint to changed files #4184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
format.sh
Outdated
| @@ -77,7 +81,7 @@ format_changed() { | |||
| MERGEBASE="$(git merge-base origin/master HEAD)" | |||
|
|
|||
| if ! git diff --diff-filter=ACM --quiet --exit-code "$MERGEBASE" -- '*.py' '*.pyi' &>/dev/null; then | |||
| git diff --name-only --diff-filter=ACM "$MERGEBASE" -- '*.py' '*.pyi' | xargs -P 5 \ | |||
| git diff --name-only --diff-filter=ACM "$MERGEBASE" -- '*.py' '*.pyi' | xargs -P 5 -d '\n' \ | |||
There was a problem hiding this comment.
Looks like -d is not available on mac:
xargs: invalid option -- d
usage: xargs [-0opt] [-E eofstr] [-I replstr [-R replacements] [-S replsize]]
[-J replstr] [-L number] [-n number [-x]] [-P maxprocs]
[-s size] [utility [argument ...]]
Any other fix than having all macos users install gnu xargs? https://superuser.com/questions/467176/replacement-for-xargs-d-in-osx
There was a problem hiding this comment.
Thanks for the catch! This only matters if there are filenames with spaces, which we probably don't expect but should still handle.
I think we can use tr '\n' '\0' | xargs -0 instead. Will update.
romilbhardwaj
approved these changes
Oct 29, 2024
yika-luo
pushed a commit
that referenced
this pull request
Oct 29, 2024
* [dev] restrict pylint to changed files * fix glob * avoid use of xargs -d
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a similar approach to what we do with yapf to limit pylint to only files that have changed from master.
On my machine this shaves about a minute off pylint runtime, making pylint 7-8x faster and format.sh 3-4x faster.
Tested (run the relevant ones):
bash format.sh:)pytest tests/test_smoke.pypytest tests/test_smoke.py::test_fill_in_the_nameconda deactivate; bash -i tests/backward_compatibility_tests.sh