Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ux] re-provision cluster if --fast but skypilot wheel is outdated #4200

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

[ux] re-provision cluster if --fast but skypilot wheel is outdated #4200

wants to merge 5 commits into from

Conversation

cg505
Copy link
Collaborator

@cg505 cg505 commented Oct 28, 2024 •
edited
Loading

based on #4159 - draft PR until that is merged

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • Manually tested happy path, wheel upgrade, autostop/autodown
  • All smoke tests: pytest tests/test_smoke.py
  • Relevant individual smoke tests: pytest tests/test_smoke.py::test_launch_fast,test_launch_fast_with_autostop
    • Unfortunately we don't have a good way to smoke test a wheel update outside of backward compatibility tests.
  • Backward compatibility tests: conda deactivate; bash -i tests/backward_compatibility_tests.sh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cg505