Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests] Fix public bucket tests #4216

Merged
merged 1 commit into from
Oct 30, 2024
Merged

[Tests] Fix public bucket tests #4216

merged 1 commit into from
Oct 30, 2024

Conversation

romilbhardwaj
Copy link
Collaborator

@romilbhardwaj romilbhardwaj commented Oct 30, 2024

sky-imagenet-data is no longer public. Changes to an actual public S3 bucket.

  • pytest tests/test_smoke.py::test_managed_jobs_storage --aws

@romilbhardwaj romilbhardwaj requested review from Michaelvll and yika-luo and removed request for Michaelvll October 30, 2024 20:51
@romilbhardwaj romilbhardwaj added this to the v0.7 milestone Oct 30, 2024
@Michaelvll
Copy link
Collaborator

A future TODO: we need to add a test for testing the access to a user's private bucket on the remote cluster.

Copy link
Collaborator

@yika-luo yika-luo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@romilbhardwaj
Copy link
Collaborator Author

A future TODO: we need to add a test for testing the access to a user's private bucket on the remote cluster.

For regular sky launch, this should be covered in the test_<cloud>_storage_mounts_with_stop series of tests. For managed jobs we test COPY mode mounting of private buckets in test_managed_jobs_storage, but not MOUNT mode...

@romilbhardwaj romilbhardwaj added this pull request to the merge queue Oct 30, 2024
Merged via the queue into master with commit 104b938 Oct 30, 2024
20 checks passed
@romilbhardwaj romilbhardwaj deleted the smoke_s3bucket_fix branch October 30, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants