Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX] Show 0.25 on controller queue #4230

Merged
merged 2 commits into from
Oct 31, 2024
Merged

Conversation

Michaelvll
Copy link
Collaborator

@Michaelvll Michaelvll commented Oct 31, 2024

Previously for controller process on the sky queue sky-jobs-controller-<hash>, we are showing CPU:8 as the resources, it is a bit confusing for how many jobs can be run in parallel. This PR makes it CPU:0.25 instead.

See job ID 10 (new) vs job ID 9 (old)

$ sky queue sky-jobs-controller-a37461fd 
Fetching and parsing job queue...

Job queue of cluster sky-jobs-controller-a37461fd
ID  NAME                         SUBMITTED    STARTED      DURATION    RESOURCES     STATUS     LOG                                        
10  test                         39 secs ago  34 secs ago  34s         1x[CPU:0.25]  RUNNING    ~/sky_logs/sky-2024-10-31-18-18-15-660126  
9   test                         5 mins ago   5 mins ago   1m 24s      1x[CPU:8.0]   SUCCEEDED  ~/sky_logs/sky-2024-10-31-18-12-39-221597  

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • Any manual or new tests for this PR (please specify below)
  • All smoke tests: pytest tests/test_smoke.py
  • Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
  • Backward compatibility tests: conda deactivate; bash -i tests/backward_compatibility_tests.sh

@romilbhardwaj
Copy link
Collaborator

Hmm, so does RESOURCES now mean the RESOURCES consumed on the controller, and not the actual CPUs required by the job?

E..g., if I run sky jobs launch --cpus 16 -- echo hi, will it show 1x[CPU:0.25] in sky jobs queue?

@Michaelvll
Copy link
Collaborator Author

Hmm, so does RESOURCES now mean the RESOURCES consumed on the controller, and not the actual CPUs required by the job?

E..g., if I run sky jobs launch --cpus 16 -- echo hi, will it show 1x[CPU:0.25] in sky jobs queue?

sky jobs queue should show the exact resources required by a job. This change only affect the sky queue sky-jobs-controller- which should not be run most of the time by a user.

@Michaelvll Michaelvll added this pull request to the merge queue Oct 31, 2024
Merged via the queue into master with commit e8d0130 Oct 31, 2024
20 checks passed
@Michaelvll Michaelvll deleted the ux-fix-for-queue-on-controllers branch October 31, 2024 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants