Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs]: OCI key_file path clarrification #4262

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

HysunHe
Copy link
Contributor

@HysunHe HysunHe commented Nov 5, 2024

This PR is to clarrify the key_file path configuration in the oci config file.

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • Any manual or new tests for this PR (please specify below)
  • All smoke tests: pytest tests/test_smoke.py
  • Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
  • Backward compatibility tests: conda deactivate; bash -i tests/backward_compatibility_tests.sh

@Michaelvll
Copy link
Collaborator

I would prefer to handle this automatically in the code, instead of adding a comment. Do you think it would be hard to change in that way?

@HysunHe
Copy link
Contributor Author

HysunHe commented Nov 5, 2024

I would prefer to handle this automatically in the code, instead of adding a comment. Do you think it would be hard to change in that way?

Would prefer to change the code later after done merging the new provisioning API impl. We doc it before that?

@Michaelvll Michaelvll added this pull request to the merge queue Nov 5, 2024
Merged via the queue into skypilot-org:master with commit c24a0b3 Nov 5, 2024
20 checks passed
@HysunHe HysunHe deleted the patch-1 branch November 5, 2024 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants