feat: add session_status to chat.stopStream - #1634
Merged
Merged
Conversation
Adds the optional session_status argument to chat.stopStream, which sets the agent session's lifecycle status after stopping the stream (defaults to active). Serialized in RequestFormBuilder. Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
zimeg
added
enhancement
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1634 +/- ##
============================================
- Coverage 72.84% 72.80% -0.04%
+ Complexity 4533 4532 -1
============================================
Files 482 482
Lines 14422 14423 +1
Branches 1512 1512
============================================
- Hits 10505 10501 -4
- Misses 3022 3025 +3
- Partials 895 897 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
Member
Author
|
📣 This'll be nice to land now for upcoming release! And also perhaps to include with #1545! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the optional
session_statusargument tochat.stopStream. When stopping a stream, an app can set the agent session's lifecycle status in the same call.sessionStatus— the session status to set after stopping the stream. Defaults toactive.What's included
sessionStatusfield onChatStopStreamRequestsession_statusform serialization inRequestFormBuilderCategory
Notes
Companion to the agent sessions work (
agents.sessions.*methods #1633). Draft — intended to land in the same release window, timed at/after the argument is published in the public method reference.Requirements
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.