fix(install): qualify Windows archive extraction - #652
Open
codywilliamson wants to merge 2 commits into
Open
Conversation
Use the Microsoft.PowerShell.Archive cmdlet explicitly so modules such as Pscx cannot shadow the installer extraction command. Add a focused Windows regression test for both installer variants.\n\nFixes slackapi#651.
|
Thanks for the contribution! Before we can merge this, we need @codywilliamson to sign the Salesforce Inc. Contributor License Agreement. |
salesforce-cla
Bot
added
cla:signed
zimeg
added
bug
zimeg
approved these changes
Aug 28, 2026
zimeg
left a comment
zimeg
left a comment
Member
There was a problem hiding this comment.
@codywilliamson Super appreciate this changeset landing here! I'm finding it continues to work as we hope and the tests are nice to confirm this.
Before merging I'm hoping to make a few small changes to tests and CI so we can keep this confidence high 🏆
|
|
||
| delay 0.3 "Extracting the executable to:`n $slack_cli_new_binary_path" | ||
| Expand-Archive "$($slack_cli_dir)\slack_cli.zip" -DestinationPath "$($slack_cli_dir)" -Force | ||
| Microsoft.PowerShell.Archive\Expand-Archive "$($slack_cli_dir)\slack_cli.zip" -DestinationPath "$($slack_cli_dir)" -Force |
Member
There was a problem hiding this comment.
🌟 praise: Thanks for making this step more stable!
The prior Windows test only lint-checked the AST for the qualified Expand-Archive call, then exercised a re-implemented extraction snippet that shadowed a *function* named Expand-Archive — it never ran the installer, so it could not catch the module-command shadow that slackapi#651 actually hit (Pscx's Expand-Archive winning unqualified resolution). Rework it to mirror the Unix install-test.sh pattern: for each Windows installer (release + dev), keep the AST guard, then actually invoke the installer and assert the aliased binary lands and reports a version. Move install tests out of the macOS-only lint-test job into a dedicated install-tests job with an OS matrix (macos/ubuntu/windows) so all three platforms' installers are exercised on every PR. Unix runs make test-install; Windows runs the reworked script. Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #652 +/- ##
==========================================
+ Coverage 72.55% 72.58% +0.02%
==========================================
Files 239 239
Lines 20229 20229
==========================================
+ Hits 14677 14683 +6
+ Misses 4277 4273 -4
+ Partials 1275 1273 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
The Windows installer now extracts the CLI reliably when another PowerShell module defines
Expand-Archive.Summary
PowerShell resolves an unqualified command name before binding its parameters. When Pscx 3.3.2 is loaded, the installer selects Pscx's
Expand-Archive, which does not accept-DestinationPath; the ZIP downloads successfully, but extraction and the PATH update never happen. Both release and development installers now addressMicrosoft.PowerShell.Archiveexplicitly.Fixes #651.
The regression test is the part worth the closest review. It keeps the change dependency-free: it parses both mirrored installers to require the qualified command, then performs a real extraction while a same-named function shadows unqualified command resolution.
Testing
Both commands pass locally.
go test ./...was also attempted with the repository-requested Go 1.26.6 toolchain on Windows/386, but unrelated command packages simultaneously reached the suite's 11-minute watchdog. The pull request's macOS Go suite remains the authoritative repository-wide check.Notes
The CLI runtime and non-Windows installers are unchanged. The added Windows job runs only the focused, Pester-free installer regression.
Requirements