Fixup cert package tests #1253
Open
Fixup cert package tests #1253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbrownus
force-pushed
the
certv1-tests
branch
from
b38e4f0
to
53b352e
Compare
nbrownus
force-pushed
the
certv1-tests
branch
from
53b352e
to
c12d8da
Compare
nbrownus
commented
Oct 18, 2024
| package e2e | ||
| package cert | ||
|
|
||
| //TODO: this should only be built if performing tests |
There was a problem hiding this comment.
I really dont want to require we use a tag to execute tests but it also feels bad to include this in the binary and I don't know of another way to deal with this without just copying these functions all over the place again.
There was a problem hiding this comment.
can't you define these in a something_helpers_test.go and use them in other *_test.go files?
There was a problem hiding this comment.
I desperately want there to be a way but the only thing I can come up with is a build tag much like how e2e works
|
Could knock out #1124 in this too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes the old v1 tests and adds new tests for v2.
Most notably it fixes the
TestMarshalingCertificateV1Consistencytest which needed to be modified.netip.Prefixcan not represent netmasks like255.0.255.0. I went back to f22b4b5 and modified the test details to remove the non conforming netmasks and adjust the timestamps, the resulting expected byte arrays are represented in this test.There are two spots where I am unsure if we want to panic, v1 and v2
String()callsjson.Marshalwhich can fail. Currently they return a string but panic would be more obvious.