Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sn ExternalQualityMetric submission template #235

Merged
merged 17 commits into from
Oct 21, 2024
Merged

Conversation

sarahgonicholson
Copy link
Contributor

@sarahgonicholson sarahgonicholson commented Aug 29, 2024

In commands/write_submission_spreadsheets.py:

  • Add --eqm [dsa duplexseq] argument that grabs tooltip, key, and derived_from from the appropriate ExternalQualityMetric template and writes out to a new tab in the spreadsheet
  • Remove properties from DonorSpecificAssembly that are now on ExternalQualityMetric
  • Example spreadsheets for DSA and DuplexSeq

Copy link
Contributor

@alexander-veit alexander-veit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@@ -205,15 +212,20 @@ def get_spreadsheets(
order = items
return reorder_spreadsheets(spreadsheets,order)
if items:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could make this shorter (not tested):

spreadsheets = [
    get_spreadsheet(item, submission_schema)
    for item, submission_schema in ordered_submission_schemas.items()
    if not items or item in items
]

But it's maybe harder to read. Up to you.

@sarahgonicholson sarahgonicholson merged commit ddf580b into main Oct 21, 2024
2 checks passed
@sarahgonicholson sarahgonicholson deleted the sn_eqm_submission branch October 21, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants