Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React bootstrap v2, React 18, Redux and Misc. Npm Packages Upgrade #263

Merged
merged 96 commits into from
Oct 18, 2024

Conversation

Onurcankaratay
Copy link
Contributor

This pull request primarily addresses the transition from React 17 to React 18, while also including updates for Redux, Auth0, and other third-party integrations heavily used in the portal, ensuring compatibility with React 18.

Ticket: Trello 1 & Trello 2
Related PR: SPC

Updates

  • React: Upgraded from v17 to v18
  • Redux: Updated from v4 to v5
  • Auth0-Lock: Upgraded from v11 to v12
  • Gulp.js: Updated from v4 to v5

Additionally, this pull request implements the migration to Bootstrap v5 and updates to React-Bootstrap v2, ensuring that styles and components are fully compatible with the latest standards.

  • Bootstrap v5 Migration: Adapted styles and class names to align with Bootstrap 5.
  • React-Bootstrap v2 Update: Updated components and class names to conform to React-Bootstrap 2 standards.
  • FontAwesome v6 Integration: Upgraded to FontAwesome v6 to resolve console SCSS build warnings and ensure future compatibility.

Note: React-Bootstrap v2 encompasses React 18, so it can be disregarded. PR

@Onurcankaratay
Copy link
Contributor Author

@Bianca-Morris, @crfmc Thanks for your detailed review. I have fixed/refactored the issues you mentioned. Could you have a look when you have a chance please - thanks.

@Bianca-Morris
Copy link
Collaborator

Bianca-Morris commented Oct 9, 2024

@Bianca-Morris, @crfmc Thanks for your detailed review. I have fixed/refactored the issues you mentioned. Could you have a look when you have a chance please - thanks.

I did look at this a small bit, and I think most of my concerns were addressed. But I haven't gotten a chance to do a full walk-through/test again, so don't want to explicitly approve.

I'll be out until next week, so if Cesar and Shannon have an opportunity to look at this and approve the final edits before then, feel free to merge it without my approval. Otherwise, if there are additional things they catch that need to be updated, I'm happy to re-review upon my return.

Thanks for your work on this!

@crfmc
Copy link
Contributor

crfmc commented Oct 16, 2024

Hi @Onurcankaratay! The only difference I noticed was that the table items on the /docs/additional-resources/sample-file-nomenclature page are centered. This is left aligned on the live site.

Otherwise, everything looks good! Thank you for addressing all of these concerns.

Screenshot 2024-10-16 at 9 16 43 AM

@Onurcankaratay
Copy link
Contributor Author

Hi @crfmc! It looks like there was an indexing issue. I reindexed the page, and it should be okay now.

Screenshot from 2024-10-16 17-39-08

@Onurcankaratay Onurcankaratay merged commit c478613 into main Oct 18, 2024
2 checks passed
@Onurcankaratay Onurcankaratay deleted the utk_react_18 branch October 18, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants