-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React bootstrap v2, React 18, Redux and Misc. Npm Packages Upgrade #263
Conversation
@Bianca-Morris, @crfmc Thanks for your detailed review. I have fixed/refactored the issues you mentioned. Could you have a look when you have a chance please - thanks. |
I did look at this a small bit, and I think most of my concerns were addressed. But I haven't gotten a chance to do a full walk-through/test again, so don't want to explicitly approve. I'll be out until next week, so if Cesar and Shannon have an opportunity to look at this and approve the final edits before then, feel free to merge it without my approval. Otherwise, if there are additional things they catch that need to be updated, I'm happy to re-review upon my return. Thanks for your work on this! |
Hi @Onurcankaratay! The only difference I noticed was that the table items on the Otherwise, everything looks good! Thank you for addressing all of these concerns. |
Hi @crfmc! It looks like there was an indexing issue. I reindexed the page, and it should be okay now. |
This pull request primarily addresses the transition from React 17 to React 18, while also including updates for Redux, Auth0, and other third-party integrations heavily used in the portal, ensuring compatibility with React 18.
Ticket: Trello 1 & Trello 2
Related PR: SPC
Updates
Additionally, this pull request implements the migration to Bootstrap v5 and updates to React-Bootstrap v2, ensuring that styles and components are fully compatible with the latest standards.
Note: React-Bootstrap v2 encompasses React 18, so it can be disregarded. PR