Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node v20 Upgrade #266

Merged
merged 7 commits into from
Oct 16, 2024
Merged

Node v20 Upgrade #266

merged 7 commits into from
Oct 16, 2024

Conversation

Onurcankaratay
Copy link
Contributor

@Onurcankaratay Onurcankaratay commented Oct 1, 2024

Trello: https://trello.com/c/BNJY5juG/348-nodejs-v20-upgrade-for-smaht

Upgrades

  • Dockerfile's node version (tested by running > make build-docker-local)
  • GH actions main.yml that is the default workflow for master and PRs. (also bumps actions/checkout and actions/python-setup (tested by running on Github actions manually)

image

How to install/use Node 20 using NVM

To install Node.js 20 using nvm (Node Version Manager) on a Mac, follow these steps:

1. Install nvm (if you haven't already)

If you don't have nvm installed, you can do so by running the following command in your terminal:

curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.39.5/install.sh | bash

After installation, add the following to your .zshrc or .bash_profile (depending on your shell):

export NVM_DIR="$([ -z "${XDG_CONFIG_HOME-}" ] && printf %s "${HOME}/.nvm" || printf %s "${XDG_CONFIG_HOME}/nvm")"
[ -s "$NVM_DIR/nvm.sh" ] && \. "$NVM_DIR/nvm.sh"

Then, restart your terminal or run:

source ~/.zshrc # or ~/.bash_profile if using bash

2. Verify nvm installation

Run this command to ensure nvm is installed:

nvm --version

If the version appears, you are ready to install Node.js.

3. Install Node.js 20

Now, you can install Node.js version 20 with this command:

nvm install 20

4. Use Node.js 20

After installation, set Node.js 20 as the default version with:

nvm use 20

To make Node.js 20 the default version for every session, run:

nvm alias default 20

5. Verify Node.js 20 Installation

To verify that Node.js 20 is installed and being used, check the version with:

node --version

You should see output like v20.x.x.

@Onurcankaratay
Copy link
Contributor Author

Copy link
Collaborator

@Bianca-Morris Bianca-Morris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not noticing any obvious issues with this on local. I'd also add @dmichaels-harvard as a reviewer, so back end team is aware we're updating this, and they can make any adjustments necessary on their end (only occasionally an issue).

Copy link
Contributor

@crfmc crfmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good locally for me as well!

@utku-ozturk utku-ozturk merged commit 0e56cdf into main Oct 16, 2024
2 checks passed
@utku-ozturk utku-ozturk deleted the utk_node_20_upgrade branch October 16, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants