SN DSA Release #277
Open
SN DSA Release #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The tests are failing. I think it's related to your latest change |
| @@ -750,14 +752,20 @@ def get_sex_abbreviation(sex: str) -> str: | |||
|
|
|||
|
|
|||
| def get_sequencing_and_assay_codes( | |||
| file: List[Dict[str, Any]], | |||
There was a problem hiding this comment.
Is this correct? Is it a list?
| @@ -816,7 +824,9 @@ def get_analysis( | |||
| software_and_versions, reference_genome_code | |||
| ) | |||
| if file_format_utils.is_chain_file(file_extension): | |||
| value = f"{value}{ANALYSIS_INFO_SEPARATOR}{get_chain_file_value(file)}" | |||
| value = ANALYSIS_INFO_SEPARATOR.join([value,get_chain_file_value(file)]) if value else get_chain_file_value(file) | |||
| if file_format_utils.is_fasta_file(file_extension): | |||
There was a problem hiding this comment.
Not quite sure I understand. You are only testing for fasta file here. Do you always want to appenddsa in that case?
There was a problem hiding this comment.
Great point. I'll add a specification for only DSA fasta files
src/encoded/commands/release_file.py
Outdated
| file_constants.DATASET: dataset, | ||
| file_constants.ACCESS_STATUS: access_status, | ||
| file_constants.ANNOTATED_FILENAME: annotated_filename_info.filename, | ||
| } | ||
|
|
||
| if not supp_file_utils.is_reference_conversion(self.file) and not supp_file_utils.is_reference_genome(self.file): |
There was a problem hiding this comment.
You are making this check already in get_file_sets_from_file. Should we just test here if file_set_accessions is empty?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
commands/release-file.pyandcommands/create-annotated-filenames.py:titleinstead ofcodefor software part of annotated filename