This repository has been archived by the owner on Feb 14, 2019. It is now read-only.
Implement pickerPosition:'auto' option #645
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 28, 2017 09:53
Even using the old defaults, 'bottom-right' css is being applied to a datepicker which is created on the left hand side and the arrow is on the left. Swapping the CSS moves the arrow to the right side even though the name would now be 'bottom-left'. Moveover, the picker would be on the left, but the arrow on the right of the picker. This should keep this working as is instead of swapping css. I worry changing the CSS would be a breaking change for many people using this library. Even if it seems correct.
jarstelfox
changed the title
added 3 commits
August 9, 2017 09:00
Offset is not enough when a parent dive has overflow:scroll/auto. We need to calculated the bottom of the document regardless of if we are in a scrollable area.
This will recalculate the auto positioning of a picker when the window is resized. This includes auto positioning, meaning a picker may flip upwards if the window is resized vertically and there is no room on the bottom of the page for the picker
This was referenced Aug 23, 2017
Open
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should resolve #209.
Testing: