Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#503 Use module_parent_name for rails 6 upwards #504

Merged
merged 1 commit into from
Jan 20, 2021
Merged

#503 Use module_parent_name for rails 6 upwards #504

merged 1 commit into from
Jan 20, 2021

Conversation

quorak
Copy link

@quorak quorak commented Jan 20, 2021

Hope this helps. Used from voormedia/rails-erd#358

@coveralls
Copy link

coveralls commented Jan 20, 2021 •
edited
Loading

Coverage Status

Coverage decreased (-0.1%) to 96.862% when pulling fcbb970 on quorak:quorak-patch-module_parent_name into 28b2f33 on smartinez87:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 96.824% when pulling fcbb970 on quorak:quorak-patch-module_parent_name into 28b2f33 on smartinez87:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 96.824% when pulling fcbb970 on quorak:quorak-patch-module_parent_name into 28b2f33 on smartinez87:master.

@smartinez87 smartinez87 merged commit e9f09b8 into smartinez87:master Jan 20, 2021
@smartinez87
Copy link
Owner

thanks @quorak !

@ansonhoyt
Copy link

Thanks @quorak, good fix. It addresses both the deprecation with 6.0 and removal with 6.1.

@smartinez87 would you be up for releasing this?

@ansonhoyt ansonhoyt mentioned this pull request Apr 20, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@quorak @coveralls @smartinez87 @ansonhoyt