fix: in composer.lock, avoid homepage item missing error.

smeghead · Jan 29, 2024 · 77d502f · 77d502f
1 parent e1711a2
commit 77d502f
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 3 deletions.
diff --git a/src/Lib/Composer/LockFile.php b/src/Lib/Composer/LockFile.php
@@ -24,7 +24,7 @@ public function getPackages(): array
         $packages = [];
         foreach ($this->object->{'packages'} as $p) {
             $name = $p->name;
-            $url = $p->homepage;
+            $url = property_exists($p, 'homepage') ? $p->homepage : '';
             $packages[] = new Package($name, $url);
         }
         return $packages;

diff --git a/test/unit/Lib/Composer/LockFileTest.php b/test/unit/Lib/Composer/LockFileTest.php
@@ -47,8 +47,29 @@ public function testNormal(): void
         $this->assertSame(1, count($packages));
         $this->assertSame('doctrine/instantiator', $packages[0]->getName());
         $this->assertSame('https://www.doctrine-project.org/projects/instantiator.html', $packages[0]->getUrl());
-        // $this->assertSame('x', $packages[0]->getfilePath());
-        // $this->assertSame('', $packages[0]->getContent());
+    }
+
+    public function testNoHomepage(): void
+    {
+
+        $json = <<<EOJ
+{
+    "packages": [
+        {
+            "name": "doctrine/instantiator",
+            "version": "1.5.0",
+            "license": [
+                "MIT"
+            ]
+        }
+    ]
+}
+EOJ;
+        $sut = new LockFile($json);
+        $packages = $sut->getPackages();
 
+        $this->assertSame(1, count($packages));
+        $this->assertSame('doctrine/instantiator', $packages[0]->getName());
+        $this->assertSame('', $packages[0]->getUrl());
     }
 }