Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v2.2.0 #72

Merged
merged 1 commit into from
Mar 30, 2024
Merged

v2.2.0 #72

merged 1 commit into from
Mar 30, 2024

Conversation

notgull
Copy link
Member

@notgull notgull commented Mar 30, 2024

@notgull
v2.2.0
9b14d03 
Signed-off-by: John Nunley <dev@notgull.net>
@taiki-e
Copy link
Collaborator

taiki-e commented Mar 30, 2024 •
edited
Loading

We have tried a different implementation on Linux before and broke things (#55), but I don't think a regression test for that case was added.

Is it possible to test if the new implementation does not cause such a regression? (Or has it already been tested?)

@notgull
Copy link
Member Author

notgull commented Mar 30, 2024

I added a test in #73

taiki-e
taiki-e approved these changes Mar 30, 2024
View reviewed changes
Copy link
Collaborator

@taiki-e taiki-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@notgull notgull merged commit 581c0a0 into master Mar 30, 2024
14 checks passed
@notgull notgull deleted the notgull/next branch March 30, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taiki-e taiki-e taiki-e approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@notgull @taiki-e