Add a way to provide your own seed to racey futures #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit prevents these functions from needed to make calls into thread-local storage for every poll. Signed-off-by: John Nunley <dev@notgull.net>
fogti
reviewed
Sep 2, 2023
fogti
approved these changes
Sep 3, 2023
The race functions were not available on no_std targets. This commit adds "with_seed" variants that take a u64 seed that is passed to fastrand. It can be used on no_std targets to provide random racey futures and streams. A "race" feature is added that enables it. This way fastrand doesn't become a dependency for crates that don't need it, like async-io. Signed-off-by: John Nunley <dev@notgull.net>
This prevents memchr compile errors for now. Signed-off-by: John Nunley <dev@notgull.net>
notgull
force-pushed
the
notgull/efficient-rng
branch
from
1639427
to
b85ecf5
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The race functions were not available on no_std targets. This commit
adds "with_seed" variants that take a u64 seed that is passed to
fastrand. It can be used on no_std targets to provide random racey
futures and streams.
A "race" feature is added that enables it. This way fastrand doesn't
become a dependency for crates that don't need it, like async-io.
As part of this change, each racy futures provides its own
Rnginstance.