Fix/browser breadcrumb and loading - #55
Merged
Merged
Conversation
Increase breadcrumb bottom padding so text descenders are not trimmed by the horizontal ScrollView, and replace the bare spinner with a skeleton row list while a directory loads.
Wrap the horizontal breadcrumb ScrollView in a fixed 44pt container with vertically centered chips so text descenders are never clipped and the bar no longer changes height as crumbs or loading state change.
The load effect omitted the path argument from its dependencies, so selecting a directory never refetched; only pull-to-refresh worked.
The first crumb carried a null path so pressing it did nothing. Give it an empty path which resolves to the project root.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.