Merge pull request #35 from snyk-tech-services/fix/new-endpoints-failure

fix: remove qs from endpoint name and swap nolimitmode flag
snyk-labs · Sep 17, 2021 · 957c90b · 957c90b
2 parents 12df192 + 36b6dff
commit 957c90b
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/src/lib/generators/generate.ts b/src/lib/generators/generate.ts
@@ -67,6 +67,7 @@ const generateClass = (
   abstractionImportsArray.push(
     generateImportsForAbstractionMethods(classToGenerate),
   );
+  abstractionImportsArray = [...new Set(abstractionImportsArray)];
 
   if (classToGenerate) {
     if (isRootClass) {
@@ -777,7 +778,7 @@ const generatePaginationMethods = (
         method.argsList = method.argsList
           .filter((x) => !x.startsWith('perPage'))
           .filter((x) => !x.startsWith('page'));
-        method.argsList.unshift('noLimitMode: boolean = false');
+        method.argsList.push('noLimitMode: boolean = false');
 
         let qsIfStatements = '';
         qsParametersNamesList.forEach((qsParameterName) => {
@@ -1004,6 +1005,6 @@ parsedJSON.forEach((classItem) => {
   const classCode = generateClass(classItem);
   fs.writeFileSync(
     path.join('./src/lib/client/generated/' + classItem.name + '.ts'),
-    initLines + abstractionImportsArray.join(`\n`) + classCode,
+    initLines + abstractionImportsArray.join(`\n`) + '\n' + classCode,
   );
 });
diff --git a/src/lib/preprocessors/prepare.ts b/src/lib/preprocessors/prepare.ts
@@ -330,7 +330,10 @@ const main = (jsonPath: string) => {
   paths = consolidateReferences(paths);
   Object.keys(paths).forEach((path) => {
     const verbs = Object.keys(paths[path]);
-    const splitEndpoint = path.split('/').filter((x) => x);
+    const splitEndpoint = path
+      .split('?')[0]
+      .split('/')
+      .filter((x) => x);
     classMap = registerEndpoint(
       classMap,
       extractClassAndParamFromEndpoint(splitEndpoint, verbs, path),