-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: disable sentry and amplitude for fedramp instance #446
Merged
bastiandoetsch
merged 10 commits into
master
from
chore/HEAD-676_disable-sentry-and-amplitude-on-fedramp
Aug 31, 2023
Merged
chore: disable sentry and amplitude for fedramp instance #446
bastiandoetsch
merged 10 commits into
master
from
chore/HEAD-676_disable-sentry-and-amplitude-on-fedramp
Aug 31, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avishagp
approved these changes
Aug 29, 2023
Will merge this after #444 |
…e-on-fedramp # Conflicts: # src/main/kotlin/io/snyk/plugin/services/SnykAnalyticsService.kt # src/test/kotlin/io/snyk/plugin/cli/ConsoleCommandRunnerTest.kt
bastiandoetsch
force-pushed
the
chore/HEAD-676_disable-sentry-and-amplitude-on-fedramp
branch
from
August 31, 2023 15:06
c4cda66
to
6ff532e
Compare
Avishagp
approved these changes
Aug 31, 2023
bastiandoetsch
deleted the
chore/HEAD-676_disable-sentry-and-amplitude-on-fedramp
branch
August 31, 2023 16:31
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As Amplitude & Sentry are not fedramp compliant, we disable them on a fedramp endpoint. Fedramp endpoints are identified by:
Checklist
Screenshots / GIFs
Visuals that may help the reviewer. Please add screenshots for any UI change. GIFs are most welcome!