Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: disable sentry and amplitude for fedramp instance #446

Merged

Conversation

bastiandoetsch
Copy link
Collaborator

@bastiandoetsch bastiandoetsch commented Aug 28, 2023

Description

As Amplitude & Sentry are not fedramp compliant, we disable them on a fedramp endpoint. Fedramp endpoints are identified by:

  • having a snykgov.io domain

Checklist

  • Tests added and all succeed
  • Linted
  • CHANGELOG.md updated
  • README.md updated, if user-facing

Screenshots / GIFs

Visuals that may help the reviewer. Please add screenshots for any UI change. GIFs are most welcome!

@bastiandoetsch bastiandoetsch requested a review from a team as a code owner August 28, 2023 12:32
@bastiandoetsch
Copy link
Collaborator Author

Will merge this after #444

…e-on-fedramp

# Conflicts:
#	src/main/kotlin/io/snyk/plugin/services/SnykAnalyticsService.kt
#	src/test/kotlin/io/snyk/plugin/cli/ConsoleCommandRunnerTest.kt
@bastiandoetsch bastiandoetsch force-pushed the chore/HEAD-676_disable-sentry-and-amplitude-on-fedramp branch from c4cda66 to 6ff532e Compare August 31, 2023 15:06
@bastiandoetsch bastiandoetsch merged commit 013d0d6 into master Aug 31, 2023
8 checks passed
@bastiandoetsch bastiandoetsch deleted the chore/HEAD-676_disable-sentry-and-amplitude-on-fedramp branch August 31, 2023 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants