Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Open Deep Link modal #640

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

km1chno
Copy link
Contributor

@km1chno km1chno commented Oct 21, 2024

Resolves #631

Changes

Adds "Open Deep Link" modal that allows to input a deep link to open in app and browse history of recently opened deep links, which is cached in workspace state.

Demos (dark and light mode)

deeplinks_demo_dark.mov
deeplinks_demo_light.mov

How Has This Been Tested:

Tested in light and dark mode, on Iphone 15 Pro sim and Pixel 9 emulator, on projects expo-router and react-native-75.

Copy link

vercel bot commented Oct 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
radon-ide ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 21, 2024 8:09am

@km1chno km1chno self-assigned this Oct 21, 2024
Copy link
Member

@kmagiera kmagiera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I haven't reviewed the code yet, wanted to add some UX related comments based on the videos you attached:

  1. It doesn't feel good when the height of the dialog changes when you type (there are less choices as you narrow down the search, but shifting the modal makes it difficult to type or follow).
  2. I think it'd make sense for this to work similarily to the browser URL bar, specifically it doesn't seem like we really need to input fields for the URL and for search separately. The main one should be a typeahead (using past history) input

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Deep Link dialog
2 participants