Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

activeCursor prop #2550

Merged
merged 13 commits into from
Jul 20, 2023
Merged

activeCursor prop #2550

merged 13 commits into from
Jul 20, 2023

Conversation

m-bert
Copy link
Contributor

@m-bert m-bert commented Jul 19, 2023

Description

This PR adds activeCursor prop which allows users to change cursor appearance upon handler activation. Initially it was added in 2.6.1 as a response to this issue. However, not everyone liked the idea (which is understandable), so we decided to turn this change into property. This way anyone who was using it still will be able to do so, and those who didn't like the change don't have to remove it on their own.

Old API example

<PanGestureHandler activeCursor="grab">
      <View style={styles.box}></View>
</PanGestureHandler>

New API example

  const panGesture = Gesture.Pan().activeCursor('wait');

  return (
    <GestureDetector gesture={panGesture}>
      <View style={styles.box}></View>
    </GestureDetector>
  );

Test plan

Tested on example app

@m-bert m-bert requested a review from j-piasecki July 19, 2023 08:37
Copy link
Member

@j-piasecki j-piasecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@m-bert m-bert merged commit a82e859 into main Jul 20, 2023
2 checks passed
@m-bert m-bert deleted the @mbert/cursor-prop branch July 20, 2023 06:43
@hirbod
Copy link

hirbod commented Sep 19, 2023

@j-piasecki what about the exported Buttons? On web, they also did turn into a hand when a link was clicked. Can we make this configurable as well?

@m-bert
Copy link
Contributor Author

m-bert commented Sep 19, 2023

Hi @hirbod! Which Buttons do you have in mind? I've just checked RectButton and BaseButton and they both support activeCursor prop. Is there something that I've missed?

@hirbod
Copy link

hirbod commented Sep 19, 2023

@m-bert I had to restart the TS Server, sorry about that. It didn't autocomplete the prop for me in my tests.

@hirbod
Copy link

hirbod commented Sep 19, 2023

@m-bert I tried to replicate inside this snack but it seems like it still turns the cursor into a grabbing hand (try the 2nd button)

Will need to test outside of Snack but it should work, even though its not the recommended version for snack.

Bildschirmaufnahme.2023-09-19.um.12.41.16.mp4

@m-bert
Copy link
Contributor Author

m-bert commented Sep 20, 2023

@hirbod, have you managed to test that outside of Snack? While I do see this problem while using expo snack, it works fine outside of it.

@hirbod
Copy link

hirbod commented Sep 20, 2023

@m-bert I can confirm that it works as expected outside of Snack.

renovate bot referenced this pull request in valora-inc/wallet Oct 5, 2023
…4264)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[react-native-gesture-handler](https://togithub.com/software-mansion/react-native-gesture-handler)
| [`^2.12.1` ->
`^2.13.1`](https://renovatebot.com/diffs/npm/react-native-gesture-handler/2.12.1/2.13.1)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/react-native-gesture-handler/2.13.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/react-native-gesture-handler/2.13.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/react-native-gesture-handler/2.12.1/2.13.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/react-native-gesture-handler/2.12.1/2.13.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>software-mansion/react-native-gesture-handler
(react-native-gesture-handler)</summary>

###
[`v2.13.1`](https://togithub.com/software-mansion/react-native-gesture-handler/releases/tag/2.13.1)

[Compare
Source](https://togithub.com/software-mansion/react-native-gesture-handler/compare/2.13.0...2.13.1)

#### 🐛 Bug fixes

- Hotfix: Hover not working on web by
[@&#8203;pepyta](https://togithub.com/pepyta) in
[https://github.com/software-mansion/react-native-gesture-handler/pull/2593](https://togithub.com/software-mansion/react-native-gesture-handler/pull/2593)

#### New Contributors

- [@&#8203;pepyta](https://togithub.com/pepyta) made their first
contribution in
[https://github.com/software-mansion/react-native-gesture-handler/pull/2593](https://togithub.com/software-mansion/react-native-gesture-handler/pull/2593)

**Full Changelog**:
software-mansion/react-native-gesture-handler@2.13.0...2.13.1

###
[`v2.13.0`](https://togithub.com/software-mansion/react-native-gesture-handler/releases/tag/2.13.0)

[Compare
Source](https://togithub.com/software-mansion/react-native-gesture-handler/compare/2.12.1...2.13.0)

#### ❗ Important changes

- Add `Hover` gesture by
[@&#8203;j-piasecki](https://togithub.com/j-piasecki) in
[https://github.com/software-mansion/react-native-gesture-handler/pull/2455](https://togithub.com/software-mansion/react-native-gesture-handler/pull/2455)

#### 🐛 Bug fixes

- Only cancel JS responder when activating recognizer comes from Gesture
Handler by [@&#8203;j-piasecki](https://togithub.com/j-piasecki) in
[https://github.com/software-mansion/react-native-gesture-handler/pull/2533](https://togithub.com/software-mansion/react-native-gesture-handler/pull/2533)
- Make manual activation recognizer not cancel `UIControls` by
[@&#8203;j-piasecki](https://togithub.com/j-piasecki) in
[https://github.com/software-mansion/react-native-gesture-handler/pull/2545](https://togithub.com/software-mansion/react-native-gesture-handler/pull/2545)
- fix: export SwipeableProps by
[@&#8203;G07cha](https://togithub.com/G07cha) in
[https://github.com/software-mansion/react-native-gesture-handler/pull/2561](https://togithub.com/software-mansion/react-native-gesture-handler/pull/2561)
- Fix Reanimated worklet recognition on Fabric by
[@&#8203;t0ms0n00](https://togithub.com/t0ms0n00) in
[https://github.com/software-mansion/react-native-gesture-handler/pull/2555](https://togithub.com/software-mansion/react-native-gesture-handler/pull/2555)
- Android TalkBack fix by [@&#8203;m-bert](https://togithub.com/m-bert)
in
[https://github.com/software-mansion/react-native-gesture-handler/pull/2234](https://togithub.com/software-mansion/react-native-gesture-handler/pull/2234)
- Continuously check for pointer capture on web by
[@&#8203;j-piasecki](https://togithub.com/j-piasecki) in
[https://github.com/software-mansion/react-native-gesture-handler/pull/2563](https://togithub.com/software-mansion/react-native-gesture-handler/pull/2563)
- fix: export Touchable\* component props by
[@&#8203;G07cha](https://togithub.com/G07cha) in
[https://github.com/software-mansion/react-native-gesture-handler/pull/2556](https://togithub.com/software-mansion/react-native-gesture-handler/pull/2556)
- Don't create a `RippleDrawable` when the color is transparent by
[@&#8203;j-piasecki](https://togithub.com/j-piasecki) in
[https://github.com/software-mansion/react-native-gesture-handler/pull/2575](https://togithub.com/software-mansion/react-native-gesture-handler/pull/2575)
- Fix `hitSlop` on Gesture Handler buttons by
[@&#8203;j-piasecki](https://togithub.com/j-piasecki) in
[https://github.com/software-mansion/react-native-gesture-handler/pull/2039](https://togithub.com/software-mansion/react-native-gesture-handler/pull/2039)
- Improve multi-pointer behavior (with ScrollView) on Android by
[@&#8203;j-piasecki](https://togithub.com/j-piasecki) in
[https://github.com/software-mansion/react-native-gesture-handler/pull/2551](https://togithub.com/software-mansion/react-native-gesture-handler/pull/2551)
- Fix ripple effect staying after cancellation by
[@&#8203;m-bert](https://togithub.com/m-bert) in
[https://github.com/software-mansion/react-native-gesture-handler/pull/2586](https://togithub.com/software-mansion/react-native-gesture-handler/pull/2586)
- Fix react-android not found error on android by
[@&#8203;lauhon](https://togithub.com/lauhon) in
[https://github.com/software-mansion/react-native-gesture-handler/pull/2568](https://togithub.com/software-mansion/react-native-gesture-handler/pull/2568)

#### 👍 Improvements

- `activeCursor` prop by [@&#8203;m-bert](https://togithub.com/m-bert)
in
[https://github.com/software-mansion/react-native-gesture-handler/pull/2550](https://togithub.com/software-mansion/react-native-gesture-handler/pull/2550)
- Update default Android SDK versions by
[@&#8203;makito013](https://togithub.com/makito013) in
[https://github.com/software-mansion/react-native-gesture-handler/pull/2537](https://togithub.com/software-mansion/react-native-gesture-handler/pull/2537)
- Recycle obtained `MotionEvents` on Android by
[@&#8203;j-piasecki](https://togithub.com/j-piasecki) in
[https://github.com/software-mansion/react-native-gesture-handler/pull/2523](https://togithub.com/software-mansion/react-native-gesture-handler/pull/2523)
- Documentation: link leading to a 404 fix by
[@&#8203;orpos](https://togithub.com/orpos) in
[https://github.com/software-mansion/react-native-gesture-handler/pull/2553](https://togithub.com/software-mansion/react-native-gesture-handler/pull/2553)
- Decouple the JS implementation from the web APIs by
[@&#8203;j-piasecki](https://togithub.com/j-piasecki) in
[https://github.com/software-mansion/react-native-gesture-handler/pull/2579](https://togithub.com/software-mansion/react-native-gesture-handler/pull/2579)
- Remove multiple instances check when building by
[@&#8203;j-piasecki](https://togithub.com/j-piasecki) in
[https://github.com/software-mansion/react-native-gesture-handler/pull/2569](https://togithub.com/software-mansion/react-native-gesture-handler/pull/2569)

#### 🔢 Miscellaneous

- Bump fast-xml-parser from 4.1.3 to 4.2.4 in /example by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/software-mansion/react-native-gesture-handler/pull/2512](https://togithub.com/software-mansion/react-native-gesture-handler/pull/2512)
- Bump fast-xml-parser from 4.2.2 to 4.2.4 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/software-mansion/react-native-gesture-handler/pull/2511](https://togithub.com/software-mansion/react-native-gesture-handler/pull/2511)
- Bump activesupport from 6.1.7.2 to 7.0.5 in /example by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/software-mansion/react-native-gesture-handler/pull/2509](https://togithub.com/software-mansion/react-native-gesture-handler/pull/2509)
- Bump shell-quote from 1.7.2 to 1.8.1 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/software-mansion/react-native-gesture-handler/pull/2521](https://togithub.com/software-mansion/react-native-gesture-handler/pull/2521)
- Bump tough-cookie from 4.0.0 to 4.1.3 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/software-mansion/react-native-gesture-handler/pull/2531](https://togithub.com/software-mansion/react-native-gesture-handler/pull/2531)
- Bump semver from 5.7.1 to 5.7.2 in /example by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/software-mansion/react-native-gesture-handler/pull/2540](https://togithub.com/software-mansion/react-native-gesture-handler/pull/2540)
- Bump semver from 5.7.1 to 5.7.2 in /docs by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/software-mansion/react-native-gesture-handler/pull/2539](https://togithub.com/software-mansion/react-native-gesture-handler/pull/2539)
- Bump fast-xml-parser from 4.2.4 to 4.2.5 in /example by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/software-mansion/react-native-gesture-handler/pull/2535](https://togithub.com/software-mansion/react-native-gesture-handler/pull/2535)
- Bump semver from 5.7.1 to 5.7.2 in /e2e/web-tests by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/software-mansion/react-native-gesture-handler/pull/2541](https://togithub.com/software-mansion/react-native-gesture-handler/pull/2541)
- Bump semver from 5.7.1 to 5.7.2 in /FabricExample by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/software-mansion/react-native-gesture-handler/pull/2542](https://togithub.com/software-mansion/react-native-gesture-handler/pull/2542)
- Bump semver from 5.7.1 to 5.7.2 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/software-mansion/react-native-gesture-handler/pull/2538](https://togithub.com/software-mansion/react-native-gesture-handler/pull/2538)
- Bump fast-xml-parser from 4.2.4 to 4.2.5 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/software-mansion/react-native-gesture-handler/pull/2534](https://togithub.com/software-mansion/react-native-gesture-handler/pull/2534)
- Bump word-wrap from 1.2.3 to 1.2.4 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/software-mansion/react-native-gesture-handler/pull/2547](https://togithub.com/software-mansion/react-native-gesture-handler/pull/2547)
- Bump word-wrap from 1.2.3 to 1.2.4 in /example by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/software-mansion/react-native-gesture-handler/pull/2548](https://togithub.com/software-mansion/react-native-gesture-handler/pull/2548)
- Bump word-wrap from 1.2.3 to 1.2.4 in /FabricExample by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/software-mansion/react-native-gesture-handler/pull/2549](https://togithub.com/software-mansion/react-native-gesture-handler/pull/2549)
- Update `docusaurus` to 2.3.1 by
[@&#8203;j-piasecki](https://togithub.com/j-piasecki) in
[https://github.com/software-mansion/react-native-gesture-handler/pull/2423](https://togithub.com/software-mansion/react-native-gesture-handler/pull/2423)
- Add empty example by [@&#8203;m-bert](https://togithub.com/m-bert) in
[https://github.com/software-mansion/react-native-gesture-handler/pull/2564](https://togithub.com/software-mansion/react-native-gesture-handler/pull/2564)
- Add description to `averageTouches` in the documentation by
[@&#8203;j-piasecki](https://togithub.com/j-piasecki) in
[https://github.com/software-mansion/react-native-gesture-handler/pull/2352](https://togithub.com/software-mansion/react-native-gesture-handler/pull/2352)
- Update the team in docs by
[@&#8203;j-piasecki](https://togithub.com/j-piasecki) in
[https://github.com/software-mansion/react-native-gesture-handler/pull/2565](https://togithub.com/software-mansion/react-native-gesture-handler/pull/2565)
- Bump activesupport from 7.0.5 to 7.0.7.2 in /example by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/software-mansion/react-native-gesture-handler/pull/2574](https://togithub.com/software-mansion/react-native-gesture-handler/pull/2574)
- Create FUNDING.yml by [@&#8203;aleqsio](https://togithub.com/aleqsio)
in
[https://github.com/software-mansion/react-native-gesture-handler/pull/2587](https://togithub.com/software-mansion/react-native-gesture-handler/pull/2587)

#### New Contributors

- [@&#8203;makito013](https://togithub.com/makito013) made their first
contribution in
[https://github.com/software-mansion/react-native-gesture-handler/pull/2537](https://togithub.com/software-mansion/react-native-gesture-handler/pull/2537)
- [@&#8203;orpos](https://togithub.com/orpos) made their first
contribution in
[https://github.com/software-mansion/react-native-gesture-handler/pull/2553](https://togithub.com/software-mansion/react-native-gesture-handler/pull/2553)
- [@&#8203;t0ms0n00](https://togithub.com/t0ms0n00) made their first
contribution in
[https://github.com/software-mansion/react-native-gesture-handler/pull/2555](https://togithub.com/software-mansion/react-native-gesture-handler/pull/2555)
- [@&#8203;G07cha](https://togithub.com/G07cha) made their first
contribution in
[https://github.com/software-mansion/react-native-gesture-handler/pull/2561](https://togithub.com/software-mansion/react-native-gesture-handler/pull/2561)
- [@&#8203;lauhon](https://togithub.com/lauhon) made their first
contribution in
[https://github.com/software-mansion/react-native-gesture-handler/pull/2568](https://togithub.com/software-mansion/react-native-gesture-handler/pull/2568)

**Full Changelog**:
software-mansion/react-native-gesture-handler@2.12.0...2.13.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone
America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone
America/Los_Angeles.

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/valora-inc/wallet).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4wLjMiLCJ1cGRhdGVkSW5WZXIiOiIzNy4wLjMiLCJ0YXJnZXRCcmFuY2giOiJtYWluIn0=-->

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Jean Regisser <jean.regisser@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants